Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Photo descriptions not displayed #393

Open
andyjohnson0 opened this issue Jan 15, 2025 · 0 comments
Open

Photo descriptions not displayed #393

andyjohnson0 opened this issue Jan 15, 2025 · 0 comments

Comments

@andyjohnson0
Copy link

Summary

I have uploaded a number of albums contains photos with description text in EXIF description, XPTitle, XPSubject, and in the IPTC caption. These descriptions are not displayed in the album thumbnail view or the individual photo view. I believe that they should be.

Context

I'm evaluating Piwigo with Bootstrap Darkroom as a personal gallery. Using the latest versions of both. I'm an experienced developer, but new to the software and the code and not very familiar with php.

Discussion

Using ExifPilot I have verified that the images I've uploaded have text in EXIF description, XPTitle, XPSubject, and in the IPTC caption. I can alsop see the IPTC description in the metadata card view.

Looking at piwigo-bootstrap-darkroom/template/index.tpl in the repo I can see the following:

{if !empty($CONTENT_DESCRIPTION)}
    <div id="content-description" class="py-3{if $theme_config->thumbnail_cat_desc == 'simple'} text-center{/if}">
{if $theme_config->thumbnail_cat_desc == 'simple'}
        <h5>{$CONTENT_DESCRIPTION}</h5>
{else}
        {$CONTENT_DESCRIPTION}
{/if}
    </div>
{/if}

This seems to be where the image description is supposed to be inserted into the generated html. But, using the browser page inspector, I'm not seeing a <div> with the id of "content-description" in my site's html -- so it seems like $CONTENT_DESCRIPTION is not being set. And github code search doesn't show it being set anywhere in either the core Piwigo repo or the Bootstrap Darkroom repo where it is set. I don't understand this: it seems like $CONTENT_DESCRIPTION should be being set and displayed, but isn't, and that this explains the symptoms I'm seeing.

Setup

Reproducible in up-to-date Firefox, Edge, and Chrome on Windows 11 x64.

I have "Show image caption" checked in the theme config. If I check or un-check "Use description rather than title for images" then I see the following

  • Un-checked: the image titles are displayed below the thumbnails (as I'd expect) but not below the full images.

  • Checked: titles are not displayed, and no descriptions are displayed either.

Changing the "Description display style" setting makes no difference to whether image descriptions are displayed.

Environment:

  • Piwigo 15.3.0
  • Bootstrap Darkroom15.b
  • Operating system: Linux
  • PHP: 8.1.22
  • MySQL: 10.6.16-MariaDB
  • Graphics Library: ImageMagick ImageMagick 7.1.0-50
  • Cache size N/A   never calculated

Activated plugins:

  • LocalFiles Editor
  • PersonalPlugin

Site URL: https://andyjohnson.uk/photos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant