Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add photos already imported to the destination album as well #22

Open
ceinmart opened this issue Apr 2, 2018 · 6 comments
Open

Add photos already imported to the destination album as well #22

ceinmart opened this issue Apr 2, 2018 · 6 comments
Labels
feature New functionality

Comments

@ceinmart
Copy link

ceinmart commented Apr 2, 2018

Hi,

This is a feature request.
At my flickr , some photos are into multiples albums.
During the import process the plugin import only to the first album found.
If possible, when this occur, where they detected some photos was imported before , include a check box to allow add theses photos to album selected at this import, since piwigo support link one photo to multiple albums.

Regards
Cesar

@samwilson samwilson added the bug label Apr 2, 2018
@samwilson
Copy link
Collaborator

Sorry about this bug. This has probably been fixed in the latest version — can you please test again with version 1.3.3 and report back? Thanks!

@ceinmart
Copy link
Author

ceinmart commented Apr 3, 2018

Hi Sam,
I think I wasn't clear at my request.
I do not consider this a bug .
When I select an album to import they show a message like that :
"146 pictures are not displayed because already existing in the database."
But I want to link theses photos to the album I'm importing right now.
Sorry if wasn't clear before.

I update the plugin and they show updating to version 1.3.2 .
Just as curiosity , now, at plugin manager they show "version auto" , I can't confirm which version is installed ?

Anyway, after update and select an album which already imported , they keep the same behave showing the message mentioned.

Thank you a lot for your effort on this.
By the way, are you accepting donation to help you keep the maintenance ?

Regards
Cesar

@samwilson
Copy link
Collaborator

I'm afraid the import process doesn't update existing photos at all, not to add to a new album nor anything else. This is because there's no way to tell what's been changed from when the photo was first imported from Flickr, and we wouldn't want to go overwriting other changes. Sorry. The best workaround might be to delete the photos in question from Pwigio and run the import again. Sorry if I'm misunderstanding your scenario.

You're right about the version information, it was not reporting correctly; this will be fixed for future upgrades.

And thanks for the kind offer, but I'm not accepting any donations directly for this. You can donate to Piwigo in general at http://piwigo.org/get-involved#donate

@ceinmart
Copy link
Author

ceinmart commented Apr 4, 2018

Hi Sam,
I'm sorry, still there somethings I do not understand yet.
If the plugin is able to identify photos already imported , why they cannot link these identified photos to the album selected during the import process?
Appear the information is there, available... simplifying , looks like just do a insert into the mysql to link the photos identified to the album selected.
I have no clue if the code structure of this import process do not allow to do something like that... but, for us, as user, appear to be possible.

Regards
Cesar

@samwilson
Copy link
Collaborator

Ah, I think I understand now: you want already-existing photos to be added the album specified at import-time? And only when a single album is specified, not when the import process is replicating the Flickr-named albums?

This would mean that a photo that was imported in the past, and then had its albums modified on Piwigo, would also be modified; this could be unexpected to some people.

I think we'd need a new checkbox near the "Import all photos in this album" field (in the import-all page, not the import-one-album page) that says something like "Add already-imported photos to this album too". Does that sound okay?

@samwilson samwilson added feature New functionality and removed bug waiting for feedback labels Apr 10, 2018
@samwilson samwilson changed the title Add photos already imported to the new album Add photos already imported to the destination album as well Apr 10, 2018
@ceinmart
Copy link
Author

Hi Sam!
Yes ,sounds perfect for me!
👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality
Projects
None yet
Development

No branches or pull requests

2 participants