Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment profiles #134

Open
kellytr opened this issue Mar 25, 2024 · 2 comments
Open

Experiment profiles #134

kellytr opened this issue Mar 25, 2024 · 2 comments

Comments

@kellytr
Copy link
Contributor

kellytr commented Mar 25, 2024

Some issues/suggestions:

  1. ‘Run profile > stop’ will stop the experiment profile wherever its last leaving off (Ex. consider a profile that starts stirring at 400 RPM and stops after 1.5 mins. If stirring is active, and the profile is stopped early, it will keep stirring indefinitely) — does this make sense for users? Would it be better to stop all jobs associated with the profile?

  2. Starting a new profile with stirring and temp automation, while temp is already running. The profile successfully starts but the temp is skipped, and a yellow notif appears after the green success notification. The profile will successfully finish and not indicate that any actions couldn't be accomplished. Suggestion = to not allow a profile to begin unless all profile activities can succeed, or allow “starting” a profile to restart/reconfigure any active activities.

  3. Experiment profile activities can be stopped via pioreactor > manage > stop on individual activities, but the profile will still appear to be running and will still “successfully execute”. However, when clicking “stop all activities”, the profile will “successfully” exit early and state ‘actions not completed’. These two “stop” actions should have the same result.

@kellytr
Copy link
Contributor Author

kellytr commented Mar 25, 2024

Bug = stirring is still running even after experiment profile has completed + success notification. Activities in the pioreactor menu show that stirring is not running. Starting+stopping stirring, and stopping all activities will not stop this stirring...

@CamDavidsonPilon
Copy link
Member

  1. This is on the roadmap: option to stop jobs started by experiment profile if profile is stopped early pioreactor#440. I don't know if this should be the default or not though. I was thinking of a keyword in the top-level of the profile: stop_on_exit: bool that users can choose.

Bug = stirring is still running even after experiment profile has completed + success notification. Activities in the pioreactor menu show that stirring is not running. Starting+stopping stirring, and stopping all activities will not stop this stirring...

Can you provide detailed replication steps for this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants