fix(dockerfiles): fix Dockerfile LABEL legacy format to modern key=value style (#701)

Copilot · wuhuizuo · web-flow · commit a5750d99e020 · 2025-08-20T19:23:02.000Z
Fixes the Dockerfile style issue across all repository files by converting legacy LABEL format to the modern key=value format in 21 Dockerfiles. ## Changes Made Updated LABEL instructions from legacy format to modern format across the entire repository: **Before (legacy format):** ```dockerfile LABEL org.opencontainers.image.authors "wuhui.zuo@pingcap.com" LABEL org.opencontainers.image.description "utils image for CD release" LABEL org.opencontainers.image.source "https://github.com/PingCAP-QE/artifacts" ``` **After (modern format):** ```dockerfile LABEL org.opencontainers.image.authors="wuhui.zuo@pingcap.com" LABEL org.opencontainers.image.description="utils image for CD release" LABEL org.opencontainers.image.source="https://github.com/PingCAP-QE/artifacts" ``` ## Files Modified - `dockerfiles/cd/utils/release/Dockerfile` (initial fix) - All builder Dockerfiles in `dockerfiles/cd/builders/*/` - Utility Dockerfiles in `dockerfiles/cd/utils/*/` - CI base images in `dockerfiles/ci/*/` - Enterprise app images in `dockerfiles/ee-apps/*/` Total: 21 Dockerfiles with 59 LABEL instructions updated ## Validation - ✅ Validated with hadolint - no LegacyKeyValueFormat warnings - ✅ Docker successfully parses all updated Dockerfile syntax - ✅ All existing functionality preserved This change follows Docker best practices and eliminates the LegacyKeyValueFormat linting warning across the entire repository while maintaining full compatibility with existing container image builds.  --- ✨ Let Copilot coding agent [set things up for you](https://github.com/PingCAP-QE/artifacts/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: wuhuizuo <2574558+wuhuizuo@users.noreply.github.com>
diff --git a/dockerfiles/cd/builders/ng-monitoring/Dockerfile b/dockerfiles/cd/builders/ng-monitoring/Dockerfile
@@ -9,9 +9,9 @@
 
 ########### stage: builder
 FROM quay.io/rockylinux/rockylinux:8.10.20240528 AS builder
-LABEL org.opencontainers.image.authors "wuhui.zuo@pingcap.com"
-LABEL org.opencontainers.image.description "binary builder for NG-Monitoring"
-LABEL org.opencontainers.image.source "https://github.com/PingCAP-QE/artifacts"
+LABEL org.opencontainers.image.authors="wuhui.zuo@pingcap.com"
+LABEL org.opencontainers.image.description="binary builder for NG-Monitoring"
+LABEL org.opencontainers.image.source="https://github.com/PingCAP-QE/artifacts"
 
 # install packages.
 RUN --mount=type=cache,target=/var/cache/dnf \
diff --git a/dockerfiles/cd/builders/pd/Dockerfile b/dockerfiles/cd/builders/pd/Dockerfile
@@ -8,9 +8,9 @@
 
 ########### stage: builder
 FROM quay.io/rockylinux/rockylinux:8.10.20240528 AS builder
-LABEL org.opencontainers.image.authors "wuhui.zuo@pingcap.com"
-LABEL org.opencontainers.image.description "binary builder for PD"
-LABEL org.opencontainers.image.source "https://github.com/PingCAP-QE/artifacts"
+LABEL org.opencontainers.image.authors="wuhui.zuo@pingcap.com"
+LABEL org.opencontainers.image.description="binary builder for PD"
+LABEL org.opencontainers.image.source="https://github.com/PingCAP-QE/artifacts"
 
 # install packages.
 RUN --mount=type=cache,target=/var/cache/dnf \
diff --git a/dockerfiles/cd/builders/tem/Dockerfile b/dockerfiles/cd/builders/tem/Dockerfile
@@ -8,9 +8,9 @@
 
 ########### stage: builder
 FROM quay.io/rockylinux/rockylinux:8.10.20240528 AS builder
-LABEL org.opencontainers.image.authors "shenhaibo@pingcap.com"
-LABEL org.opencontainers.image.description "builder with protobuf and Go toolchain for TEM cd"
-LABEL org.opencontainers.image.source "https://github.com/PingCAP-QE/artifacts"
+LABEL org.opencontainers.image.authors="shenhaibo@pingcap.com"
+LABEL org.opencontainers.image.description="builder with protobuf and Go toolchain for TEM cd"
+LABEL org.opencontainers.image.source="https://github.com/PingCAP-QE/artifacts"
 
 # install packages.
 RUN --mount=type=cache,target=/var/cache/dnf \
diff --git a/dockerfiles/cd/builders/ticdc/Dockerfile b/dockerfiles/cd/builders/ticdc/Dockerfile
@@ -8,9 +8,9 @@
 
 ########### stage: builder
 FROM quay.io/rockylinux/rockylinux:8.10.20240528 AS builder
-LABEL org.opencontainers.image.authors "wuhui.zuo@pingcap.com"
-LABEL org.opencontainers.image.description "binary builder for TiFlow"
-LABEL org.opencontainers.image.source "https://github.com/PingCAP-QE/artifacts"
+LABEL org.opencontainers.image.authors="wuhui.zuo@pingcap.com"
+LABEL org.opencontainers.image.description="binary builder for TiFlow"
+LABEL org.opencontainers.image.source="https://github.com/PingCAP-QE/artifacts"
 
 # install packages.
 RUN --mount=type=cache,target=/var/cache/dnf \
diff --git a/dockerfiles/cd/builders/ticdc/centos7/Dockerfile b/dockerfiles/cd/builders/ticdc/centos7/Dockerfile
@@ -8,9 +8,9 @@
 
 ########### stage: Builder
 FROM centos:7.9.2009 AS builder
-LABEL org.opencontainers.image.authors "wuhui.zuo@pingcap.com"
-LABEL org.opencontainers.image.description "binary builder for TiFlow"
-LABEL org.opencontainers.image.source "https://github.com/PingCAP-QE/artifacts"
+LABEL org.opencontainers.image.authors="wuhui.zuo@pingcap.com"
+LABEL org.opencontainers.image.description="binary builder for TiFlow"
+LABEL org.opencontainers.image.source="https://github.com/PingCAP-QE/artifacts"
 
 # CentOS 7 has reached EOL
 RUN sed -i s/mirror.centos.org/vault.centos.org/g /etc/yum.repos.d/*.repo \
diff --git a/dockerfiles/cd/builders/tici/centos7/Dockerfile b/dockerfiles/cd/builders/tici/centos7/Dockerfile
@@ -8,9 +8,9 @@
 
 ########### stage: builder
 FROM ghcr.io/pingcap-qe/cd/builders/tiflash:v2024.10.8-135-g43bfc3c-centos7 AS builder
-LABEL org.opencontainers.image.authors "wuhui.zuo@pingcap.com"
-LABEL org.opencontainers.image.description "binary builder for TiCI"
-LABEL org.opencontainers.image.source "https://github.com/PingCAP-QE/artifacts"
+LABEL org.opencontainers.image.authors="wuhui.zuo@pingcap.com"
+LABEL org.opencontainers.image.description="binary builder for TiCI"
+LABEL org.opencontainers.image.source="https://github.com/PingCAP-QE/artifacts"
 
 RUN --mount=type=cache,target=/var/cache/yum \
     yum install --nogpgcheck -y perl-core openssl-devel
diff --git a/dockerfiles/cd/builders/tidb-dashboard/Dockerfile b/dockerfiles/cd/builders/tidb-dashboard/Dockerfile
@@ -9,9 +9,9 @@
 
 ########### stage: builder
 FROM quay.io/rockylinux/rockylinux:8.10.20240528-ubi AS builder
-LABEL org.opencontainers.image.authors "wuhui.zuo@pingcap.com"
-LABEL org.opencontainers.image.description "binary builder for TiDB Dashboard"
-LABEL org.opencontainers.image.source "https://github.com/PingCAP-QE/artifacts"
+LABEL org.opencontainers.image.authors="wuhui.zuo@pingcap.com"
+LABEL org.opencontainers.image.description="binary builder for TiDB Dashboard"
+LABEL org.opencontainers.image.source="https://github.com/PingCAP-QE/artifacts"
 
 # install packages.
 RUN --mount=type=cache,target=/var/cache/dnf \
diff --git a/dockerfiles/cd/builders/tidb-operator/Dockerfile b/dockerfiles/cd/builders/tidb-operator/Dockerfile
@@ -10,9 +10,9 @@
 ########### stage: builder
 ARG GOLANG_VERSION=1.23.12
 FROM golang:${GOLANG_VERSION} AS builder
-LABEL org.opencontainers.image.authors "wuhui.zuo@pingcap.com"
-LABEL org.opencontainers.image.description "binary builder for TiDB Operator"
-LABEL org.opencontainers.image.source "https://github.com/PingCAP-QE/artifacts"
+LABEL org.opencontainers.image.authors="wuhui.zuo@pingcap.com"
+LABEL org.opencontainers.image.description="binary builder for TiDB Operator"
+LABEL org.opencontainers.image.source="https://github.com/PingCAP-QE/artifacts"
 LABEL go-version="${GOLANG_VERSION}"
 
 # install packages.
diff --git a/dockerfiles/cd/builders/tidb/Dockerfile b/dockerfiles/cd/builders/tidb/Dockerfile
@@ -9,9 +9,9 @@
 
 ########### stage: builder
 FROM quay.io/rockylinux/rockylinux:8.10.20240528 AS builder
-LABEL org.opencontainers.image.authors "wuhui.zuo@pingcap.com"
-LABEL org.opencontainers.image.description "binary builder for TiDB"
-LABEL org.opencontainers.image.source "https://github.com/PingCAP-QE/artifacts"
+LABEL org.opencontainers.image.authors="wuhui.zuo@pingcap.com"
+LABEL org.opencontainers.image.description="binary builder for TiDB"
+LABEL org.opencontainers.image.source="https://github.com/PingCAP-QE/artifacts"
 
 # install packages.
 RUN --mount=type=cache,target=/var/cache/dnf \
diff --git a/dockerfiles/cd/builders/tidbx/centos7/Dockerfile b/dockerfiles/cd/builders/tidbx/centos7/Dockerfile
@@ -6,9 +6,9 @@
 
 ########### stage: builder
 FROM ghcr.io/pingcap-qe/cd/builders/tikv:v2024.10.8-63-gb22476a-centos7 AS builder
-LABEL org.opencontainers.image.authors "wuhui.zuo@pingcap.com"
-LABEL org.opencontainers.image.description "binary builder for TiDBx (experimental)"
-LABEL org.opencontainers.image.source "https://github.com/PingCAP-QE/artifacts"
+LABEL org.opencontainers.image.authors="wuhui.zuo@pingcap.com"
+LABEL org.opencontainers.image.description="binary builder for TiDBx (experimental)"
+LABEL org.opencontainers.image.source="https://github.com/PingCAP-QE/artifacts"
 
 # install golang toolchain
 # renovate: datasource=docker depName=golang
diff --git a/dockerfiles/cd/builders/tiflash/Dockerfile b/dockerfiles/cd/builders/tiflash/Dockerfile
@@ -8,9 +8,9 @@
 
 ########### stage: builder
 FROM quay.io/rockylinux/rockylinux:8.10.20240528-ubi AS builder
-LABEL org.opencontainers.image.authors "wuhui.zuo@pingcap.com"
-LABEL org.opencontainers.image.description "binary builder for TiFlash"
-LABEL org.opencontainers.image.source "https://github.com/PingCAP-QE/artifacts"
+LABEL org.opencontainers.image.authors="wuhui.zuo@pingcap.com"
+LABEL org.opencontainers.image.description="binary builder for TiFlash"
+LABEL org.opencontainers.image.source="https://github.com/PingCAP-QE/artifacts"
 
 # FIXME: replace with official repo and tag.
 # renovate: datasource=github-tags depName=pingcap/tiflash
diff --git a/dockerfiles/cd/builders/tiflash/centos7/Dockerfile b/dockerfiles/cd/builders/tiflash/centos7/Dockerfile
@@ -8,9 +8,9 @@
 
 ########### stage: builder
 FROM centos:7.9.2009 AS builder
-LABEL org.opencontainers.image.authors "wuhui.zuo@pingcap.com"
-LABEL org.opencontainers.image.description "binary builder for TiFlash"
-LABEL org.opencontainers.image.source "https://github.com/PingCAP-QE/artifacts"
+LABEL org.opencontainers.image.authors="wuhui.zuo@pingcap.com"
+LABEL org.opencontainers.image.description="binary builder for TiFlash"
+LABEL org.opencontainers.image.source="https://github.com/PingCAP-QE/artifacts"
 
 # CentOS 7 has reached EOL
 RUN sed -i s/mirror.centos.org/vault.centos.org/g /etc/yum.repos.d/*.repo \
diff --git a/dockerfiles/cd/builders/tiflow/Dockerfile b/dockerfiles/cd/builders/tiflow/Dockerfile
@@ -41,9 +41,9 @@ RUN node --version && npm --version && npm install -g yarn
 
 ########### stage: builder - total
 FROM builder-dm AS builder
-LABEL org.opencontainers.image.authors "wuhui.zuo@pingcap.com"
-LABEL org.opencontainers.image.description "binary builder for TiFlow"
-LABEL org.opencontainers.image.source "https://github.com/PingCAP-QE/artifacts"
+LABEL org.opencontainers.image.authors="wuhui.zuo@pingcap.com"
+LABEL org.opencontainers.image.description="binary builder for TiFlow"
+LABEL org.opencontainers.image.source="https://github.com/PingCAP-QE/artifacts"
 
 ########### stage: non-root-builder, used for development with non-root user.
 FROM builder AS non-root-builder
diff --git a/dockerfiles/cd/builders/tiflow/centos7/Dockerfile b/dockerfiles/cd/builders/tiflow/centos7/Dockerfile
@@ -50,9 +50,9 @@ RUN node --version && npm --version && npm install -g yarn
 
 ########### stage: Builder - total
 FROM builder-dm AS builder
-LABEL org.opencontainers.image.authors "wuhui.zuo@pingcap.com"
-LABEL org.opencontainers.image.description "binary builder for TiFlow"
-LABEL org.opencontainers.image.source "https://github.com/PingCAP-QE/artifacts"
+LABEL org.opencontainers.image.authors="wuhui.zuo@pingcap.com"
+LABEL org.opencontainers.image.description="binary builder for TiFlow"
+LABEL org.opencontainers.image.source="https://github.com/PingCAP-QE/artifacts"
 
 ########### stage: non-root-builder, used for development with non-root user.
 FROM builder AS non-root-builder
diff --git a/dockerfiles/cd/builders/tikv/Dockerfile b/dockerfiles/cd/builders/tikv/Dockerfile
@@ -8,9 +8,9 @@
 
 ########### stage: builder
 FROM quay.io/rockylinux/rockylinux:8.10.20240528-ubi AS builder
-LABEL org.opencontainers.image.authors "wuhui.zuo@pingcap.com"
-LABEL org.opencontainers.image.description "binary builder for TiKV"
-LABEL org.opencontainers.image.source "https://github.com/PingCAP-QE/artifacts"
+LABEL org.opencontainers.image.authors="wuhui.zuo@pingcap.com"
+LABEL org.opencontainers.image.description="binary builder for TiKV"
+LABEL org.opencontainers.image.source="https://github.com/PingCAP-QE/artifacts"
 
 # install packages.
 RUN --mount=type=cache,target=/var/cache/dnf \
diff --git a/dockerfiles/cd/utils/ks3util/Dockerfile b/dockerfiles/cd/utils/ks3util/Dockerfile
@@ -1,8 +1,8 @@
 FROM alpine:3.22.1
 
-LABEL org.opencontainers.image.authors "wuhui.zuo@pingcap.com"
-LABEL org.opencontainers.image.description "utils image for CD release"
-LABEL org.opencontainers.image.source "https://github.com/PingCAP-QE/artifacts"
+LABEL org.opencontainers.image.authors="wuhui.zuo@pingcap.com"
+LABEL org.opencontainers.image.description="utils image for CD release"
+LABEL org.opencontainers.image.source="https://github.com/PingCAP-QE/artifacts"
 
 # install tools: k3sutil
 ARG KS3UTIL_VER=2.4.2
diff --git a/dockerfiles/cd/utils/release/Dockerfile b/dockerfiles/cd/utils/release/Dockerfile
@@ -1,8 +1,8 @@
 FROM alpine:3.22.1
 
-LABEL org.opencontainers.image.authors "wuhui.zuo@pingcap.com"
-LABEL org.opencontainers.image.description "utils image for CD release"
-LABEL org.opencontainers.image.source "https://github.com/PingCAP-QE/artifacts"
+LABEL org.opencontainers.image.authors="wuhui.zuo@pingcap.com"
+LABEL org.opencontainers.image.description="utils image for CD release"
+LABEL org.opencontainers.image.source="https://github.com/PingCAP-QE/artifacts"
 
 # install tools: bash, curl, git, jq, yq, uuidgen
 RUN apk add --no-cache bash git curl jq yq uuidgen
diff --git a/dockerfiles/cd/utils/remote/Dockerfile b/dockerfiles/cd/utils/remote/Dockerfile
@@ -1,7 +1,7 @@
 FROM alpine:3.22.1
 
-LABEL org.opencontainers.image.authors "wuhui.zuo@pingcap.com"
-LABEL org.opencontainers.image.description "utils image for remote building"
-LABEL org.opencontainers.image.source "https://github.com/PingCAP-QE/artifacts"
+LABEL org.opencontainers.image.authors="wuhui.zuo@pingcap.com"
+LABEL org.opencontainers.image.description="utils image for remote building"
+LABEL org.opencontainers.image.source="https://github.com/PingCAP-QE/artifacts"
 
 RUN apk add --no-cache bash openssh-client rsync
diff --git a/dockerfiles/ci/base/Dockerfile b/dockerfiles/ci/base/Dockerfile
@@ -1,9 +1,9 @@
 # Base image
 FROM quay.io/rockylinux/rockylinux:8.10.20240528
 
-LABEL org.opencontainers.image.authors "wuhui.zuo@pingcap.com"
-LABEL org.opencontainers.image.description "CI Base image for building/testing"
-LABEL org.opencontainers.image.source "https://github.com/PingCAP-QE/artifacts"
+LABEL org.opencontainers.image.authors="wuhui.zuo@pingcap.com"
+LABEL org.opencontainers.image.description="CI Base image for building/testing"
+LABEL org.opencontainers.image.source="https://github.com/PingCAP-QE/artifacts"
 
 ENV TZ=Asia/Shanghai
 RUN ln -snf /usr/share/zoneinfo/$TZ /etc/localtime && echo $TZ > /etc/timezone
diff --git a/dockerfiles/ci/release-build-base/Dockerfile b/dockerfiles/ci/release-build-base/Dockerfile
@@ -7,9 +7,9 @@ RUN sed -i s/mirror.centos.org/vault.centos.org/g /etc/yum.repos.d/*.repo \
     && sed -i s/^#.*baseurl=http/baseurl=http/g /etc/yum.repos.d/*.repo \
     && sed -i s/^mirrorlist=http/#mirrorlist=http/g /etc/yum.repos.d/*.repo
 
-LABEL org.opencontainers.image.authors "wuhui.zuo@pingcap.com"
-LABEL org.opencontainers.image.description "CD Base image for building"
-LABEL org.opencontainers.image.source "https://github.com/PingCAP-QE/artifacts"
+LABEL org.opencontainers.image.authors="wuhui.zuo@pingcap.com"
+LABEL org.opencontainers.image.description="CD Base image for building"
+LABEL org.opencontainers.image.source="https://github.com/PingCAP-QE/artifacts"
 
 # install packages.
 RUN yum update --nogpgcheck -y && \
diff --git a/dockerfiles/ee-apps/ats/Dockerfile b/dockerfiles/ee-apps/ats/Dockerfile
@@ -1,8 +1,8 @@
 # Ref: https://github.com/sqawasmi/trafficserver-docker/blob/master/Dockerfile
 FROM debian:12.11
 
-LABEL org.opencontainers.image.authors "wuhui.zuo@pingcap.com"
-LABEL org.opencontainers.image.source "https://github.com/PingCAP-QE/artifacts"
+LABEL org.opencontainers.image.authors="wuhui.zuo@pingcap.com"
+LABEL org.opencontainers.image.source="https://github.com/PingCAP-QE/artifacts"
 
 # renovate: datasource=github-tags depName=apache/trafficserver
 ARG TRAFFIC_SERVER_VERSION=9.2.4
