From d398e18861b3237dce192a971b46886c76ab70b4 Mon Sep 17 00:00:00 2001
From: Alex <avhoi83@gmail.com>
Date: Wed, 13 Dec 2023 16:13:21 -0800
Subject: [PATCH] add dialogs when admins edit other users (#1530)

* created a dialog on editing EditableTexts by admins in user

* refresh the user page after every change

* switched to standard system of getting DB info for users

* Revert "switched to standard system of getting DB info for users"

This reverts commit 1c5a09e6992a03d6b5ee4912a478d46940905006.

* changed all self props to isCurrentUser

* separated alertOnSaveAdmin function, small changes

* changed selfEdit to isCurrentUser and removed all refetch changes
---
 src/routes/user.tsx | 41 +++++++++++++++++++++++++++++++++++------
 1 file changed, 35 insertions(+), 6 deletions(-)

diff --git a/src/routes/user.tsx b/src/routes/user.tsx
index 86e05bbf7..8845340f5 100644
--- a/src/routes/user.tsx
+++ b/src/routes/user.tsx
@@ -170,7 +170,24 @@ const DeleteUserButton = ({ user }: { user: UserInfo }) => {
   )
 }
 
-const SetPasswordButton = ({ user }: { user: UserInfo }) => {
+const alertOnSaveAdmin = async (isCurrentUser: boolean, user: UserInfo) => {
+  if (isCurrentUser) return true
+  const confirmation = await createDialog({
+    title: 'Confirm Edit',
+    description: `This is not your own profile. Are you sure you want to edit ${user.firstName} ${user.lastName}'s profile?`,
+    confirm: 'Confirm',
+    dismiss: 'Cancel',
+  })
+  return confirmation
+}
+
+const SetPasswordButton = ({
+  user,
+  isCurrentUser,
+}: {
+  user: UserInfo
+  isCurrentUser: boolean
+}) => {
   const emitError = useErrorEmitter()
   return (
     <EditableText
@@ -181,7 +198,11 @@ const SetPasswordButton = ({ user }: { user: UserInfo }) => {
       minLength={minPasswordLength}
       maxLength={maxPasswordLength}
       value={''}
-      save={(password) => modifyUser(user.id, { password }).catch(emitError)}
+      save={async (password) => {
+        if (await alertOnSaveAdmin(isCurrentUser, user)) {
+          modifyUser(user.id, { password }).catch(emitError)
+        }
+      }}
     >
       {(_password, _icon, startEditing) => (
         <Button flat onClick={startEditing}>
@@ -306,9 +327,11 @@ const UserProfileCard = ({
         <EditableText
           editable={editable}
           label="Name"
-          save={(newText) => {
+          save={async (newText) => {
             const [firstName, lastName] = newText.split(/\s+/)
-            return updateUser(user.id, { firstName, lastName })
+            if (await alertOnSaveAdmin(isCurrentUser, user)) {
+              return updateUser(user.id, { firstName, lastName })
+            }
           }}
           value={`${user.firstName} ${user.lastName}`}
         >
@@ -321,7 +344,11 @@ const UserProfileCard = ({
         <EditableText
           editable={editable}
           label="Username"
-          save={(username) => updateUser(user.id, { username })}
+          save={async (username) => {
+            if (await alertOnSaveAdmin(isCurrentUser, user)) {
+              updateUser(user.id, { username })
+            }
+          }}
           value={user.username}
         >
           {(value, editIcon) => (
@@ -381,7 +408,9 @@ const UserProfileCard = ({
           />
         </dl>
         {editable && !isCurrentUser && <DeleteUserButton user={user} />}
-        {editable && <SetPasswordButton user={user} />}
+        {editable && (
+          <SetPasswordButton user={user} isCurrentUser={isCurrentUser} />
+        )}
       </ErrorBoundary>
     </Card>
   )