Windows Arm64 #37
Merged
Windows Arm64 #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laves
requested changes
Jan 27, 2025
| @@ -320,9 +331,6 @@ def process(self, text: str, utterance_end_sec): | |||
|
|
|||
| def interrupt(self): | |||
There was a problem hiding this comment.
random not here, but print(f'LLM (say ${ppn_prompt} to interrupt) > ', end='', flush=True). Makes it print ..say $Picovoice to ... with the extra $. We should probably remove the $
| self.prompt = self.screen.subwin(1, self.screen.width - 2, self.screen.height - 2, 1) | ||
|
|
||
| if height >= 30 and width >= 120: | ||
| self.widgets['pcm_in'] = VerticalBar( |
There was a problem hiding this comment.
Could we maybe abstract this a tiny bit more for cleanliness? Maybe we check the height and width and call self.setDisplaySize with an enum (e.g. MINI, SMALL, MEDIUM, etc....) and this function will set up the display elements appropriately. This method allows for more flexibility in the future in the case we want to dynamically change the display size.
laves
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.