Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions & suggestions from Meta SDK migrations #7

Open
ModischFabrications opened this issue Oct 10, 2024 · 1 comment
Open

Questions & suggestions from Meta SDK migrations #7

ModischFabrications opened this issue Oct 10, 2024 · 1 comment

Comments

@ModischFabrications
Copy link

Hey, new here, currently migrating from Meta SDK to this one. I like the additional nice-to-haves like Async(), but I don't understand some differences. Could you explain the decisions and/or consider an update in future versions?

For Code:

  1. Why do I need paging for AchievementsService.GetAllDefinitions? I just want all of them, can't be that many. Why not use (0, 9999) as default? Same thing for GetAllProgress
  2. Achievement*s*Service is plural, LeaderboardService is singular
    3.AchievementsService.Unlock and similar all require an (optional?) extraData bytearray, but I don't have a need for one. Why not define a default parameter or create a version without one?
  3. Getting just my score from the scoreboard with LeaderboardService .GetEntries(id, 1, LeaderboardFilterType.None, LeaderboardStartAt.CenteredOnViewer) feels weird with Meta SDK and is not defined here, might be good to have a shortcut like GetOwnEntry()?

For Delivery:
6. Is it possible to deliver this via Unity Asset Store? Makes it much easier to import and update than the basic download and is more robust than git links
7. Pin versions as releases & tags? Makes it easier to reference them than just undocumented branches

It might also be interesting for others to have a dedicated "Migrating from Meta SDK" page that lists all these differences and offers some hints for easy migrations.

Feel free to split into separate issues. Thanks for considering!

@ModischFabrications
Copy link
Author

Another addition, but I'm losing hope that these issues here are actually read.

AchievementsService.AddCount(id, (ulong)count, ExtraData) and similar parameters could accept a ulong instead to make it equal to the oculus version, I don't think you can add negative counts anyway?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant