Add initial ULM hook implementation #26
Conversation
sskeirik
force-pushed
the
initial-ulm-hook-impl
branch
from
a89138a to
56107a3
Compare
sskeirik
force-pushed
the
initial-ulm-hook-impl
branch
from
1c11f3c to
cdfa557
Compare
|
|
||
| ```k | ||
| rule <k> PGM:PgmEncoding => . </k> | ||
| <entry> FUNCNAME </entry> |
There was a problem hiding this comment.
FUNCNAME does not seem to be used anywhere, so I guess it generates a kompile warning. Could you remove it?
There was a problem hiding this comment.
I see that you are using it in the other PR, so I guess it's fine to not remove it. However, the question above about whether the 'entry' cell with $WASM in it is a good idea is still valid.
| <k> $PGM:PgmEncoding </k> | ||
| <wasm/> | ||
| <create> $CREATE:Bool </create> | ||
| <entry> $WASM:String </entry> |
There was a problem hiding this comment.
How do you plan to use this entry cell?
Also, In the "remote" case, my guess is that the $WASM variable will not be set. If that's the case, I'm not sure what it means - will it have a default string value, or will execution fail?
|
|
||
| ```k | ||
| rule <k> PGM:PgmEncoding => . </k> | ||
| <entry> FUNCNAME </entry> |
There was a problem hiding this comment.
I see that you are using it in the other PR, so I guess it's fine to not remove it. However, the question above about whether the 'entry' cell with $WASM in it is a good idea is still valid.
| <status> Status:Int </status> | ||
|
|
||
| rule getGasLeft(_) => #getGasLeft() | ||
| rule getOutput(_) => #getOutput() |
There was a problem hiding this comment.
I'm not convinced that this will actually work in ULM, because ULM constructs a getOutput(configuration) term and evaluates it. IIRC, if you have a function f(Something) that uses the configuration (directly or indirectly) with the [[ ... ]] syntax, then kompile transforms it into f(Something, GeneratedTopCell) and silently passes the configuration as an argument. I.e., in the case above, the getOutput function is actually compiled to getOutput(GeneratedTopCell, GeneratedTopCell), which is not what ULM expects.
I might be wrong here, @traiansf for confirmation.
Also see:
https://github.com/Pi-Squared-Inc/ulm/blob/main/kllvm/ulm_kllvm.cpp#L192-L197
There was a problem hiding this comment.
As discussed on Slack, it's fine to fix this in a follow-up PR.
This PR does several things:
ulm-wasmMakefile target conditional on theULM_TESTvariable --- if this variable is set, a standalone binary will be built; otherwise, a ULM-integrated library will be builtulm-wasm.mdGASandCREATEandENTRYconfig variables toulm-wasm.mdulm-wasm.mdtangle tags to conditionally build a ULM-integrated initial configuration vs. a standalone initial configuration