Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features' Request #3

Open
abdulmoizhussain opened this issue Jul 16, 2019 · 3 comments
Open

Features' Request #3

abdulmoizhussain opened this issue Jul 16, 2019 · 3 comments

Comments

@abdulmoizhussain
Copy link

Hi, more of the following features will be great to have in PhreshPlayer:

  • Solution for: Option to change audio track of videos (as you have mentioned that it is not supported yet)

  • Increase Volume more than 100%

  • Option to skip some scenes while watching any video, using a .skip file where scenes to skip can be defined by the user (have implemented this in my fork of PhreshPlayer):
    Actually, I wanted this functionality in media player. Was unable to find any project related to this.
    But found PhreshPlayer a perfect one, in which one could add this functionality.
    Have a look at the build and implementation of my fork.
    If you find this functionality worthy enough, add it as well.

Thank you.

@Phreshhh
Copy link
Owner

Hi!

Thanks for your interest and contribution.

I want update and add new features to the player in the future, but remember: Keep It Simple!
So.. I opened for new ideas like these. I created a plugin system (in the new version) to fulfillment the rarer needs. Each user can expand his copy of the player with the features what he want..

I maked the PhreshPlayer at first and primarily for myself, cuz' i was frustrated from the new "knows everything, just the simply playback not going" players and i want a simple " just video player" player for me and i hold it to the future too. I'm selfish!? :D :P

Ur list:
Unfortunately the 1st item never will be implement i think. The chromium browser (and FF too) not supported the audio tracks in the web based video players. And if still built in, in the future, the chrome/chromium up to version 4, block automatically the ads and with this the auto start playing before user interaction in all circumstances. So in Electron too. (i tryed get around this with JS clicks, etc but i haven't succeded). So.. I don't see the way for now to make this..

The 2nd list item is more common need. I think worthy make this in a plugin in the future. (At this moment i haven't idea to the how to, but think it's a very good feature idea. I liked this in others players too.)

The 3rd item is very rare need. I never seem before this need, but as i see you maked it, so the copy/transformation to plugin is easy from now. In the weekend i 'll download your fork and try in your version.

PS:
If you make it to plugin, i add to the player plugin list and upload my server with pleasure.
In the new version ( v1.1.3 ) you can install the 3 plugin and check how to it works. The Demoplugin and the DevTools plugin is correctly commented to developers, who want make a new plugin for the player. I make just for this the Demoplugin.. :) At soon i will make a repo for the plugins only and will easier, but for the time being we can make it in this issue.

@Phreshhh
Copy link
Owner

Hi!

I created a repo for the plugins and moved your feature to a plugin with a bit mod (just for follow the minimalistic style).

Not works correctly yet (and i havent more time for this), so you need to test and fix it. - Now you can create PR.

I have a request:
The 'Skip: on/off' toast is trigger only button clicks, not all new start video.
It should work (the visible parts) same as subtitles.

Thanks

@abdulmoizhussain
Copy link
Author

Hi,

First, thank you for your brief response and consideration :)

  • Yes, I understand your motive of keeping PhreshPlayer a simple media player as possible :)
  • I will also be searching for 1st and 2nd features' solutions, and will update if I find anything applicable.
  • The plugin system is really great 👍 Specially for the rare functionalities like the "3rd" one.

Thank you once again for doing half of the work of 3rd one's plugin conversion 👍
Will definitely send a PR and complete the remaining work (including skip on/off toast only on button clicks).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants