Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Bug) Adding file without having a Category setup first #53

Open
DrBely opened this issue Apr 4, 2024 · 0 comments
Open

(Bug) Adding file without having a Category setup first #53

DrBely opened this issue Apr 4, 2024 · 0 comments

Comments

@DrBely
Copy link

DrBely commented Apr 4, 2024

Describe the bug
Looping error on adding a file while no category are available.
bug pluggin soundboard

To Reproduce

Install of the pluggin.
Skipped the config.
Downloaded the sound on this page : https://www.myinstants.com/en/instant/helldivers-2-extract-21943/
Went to the Pluggin in Macro Deck 2.
Audio files and added it.
Then the same error appeared in loop.

You have to exit Macro Deck 2 or hold ESC to be able to go out of the loop.
If you go back to pluggin--> Audio files, the error appear again.

The sound can still be used and played if you don't go back to the pluggin-->Audio files

soundboard.zip

If I create a category before, it does not do the issue BUT, if I delete all the category names after adding the files, then try to change the category of a file to an empty name, the issue rise again.

Expected behavior
Nothing

Desktop (please complete the following information):

  • OS: OS Name Microsoft Windows 10 Enterprise
  • Browser N/A
  • Version Version 10.0.19045 Build 19045

Additional context

My suggestions for a simple solution :
-Force the user to create a category first by asking in which category the user wants to add the file and adding a popup when pressing OK saying "Please create a category first" (the advantage of this would be the user choosing the category upon adding the file and not in a different action afterward)
-Creating a Default category that cannot be removed upon installation of the pluggin(Mandatory for this solution)

-(or allowing the pluggin to have no category when adding files)

@DrBely DrBely changed the title (Bug) Adding file without haveing a Category setup first (Bug) Adding file without having a Category setup first Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant