Skip to content
This repository has been archived by the owner on Jan 12, 2024. It is now read-only.

[FeatureRequest] ApplyMask transform #13

Open
haarburger opened this issue Dec 12, 2019 · 4 comments
Open

[FeatureRequest] ApplyMask transform #13

haarburger opened this issue Dec 12, 2019 · 4 comments
Assignees
Labels
FeatureRequest Request for additional feature GoodFirstPR Issues which are suited as a first PR

Comments

@haarburger
Copy link
Contributor

Description
Add a transform that applies a binary mask to an image

Proposal
Given a mask key, apply the mask to the image to set all background voxels to a predefined value

*Are you able/willing to implement the feature yourself (with some guidance from us)?
yes

@haarburger haarburger self-assigned this Dec 12, 2019
@haarburger haarburger added the FeatureRequest Request for additional feature label Dec 12, 2019
@justusschock
Copy link
Member

This might be a non-differentiable transform. We should check that and maybe add a warning if that's the case

@mibaumgartner
Copy link
Member

Could this be implemented as a multiplication?

filtered = input * mask     # filter foreground
filtered += (1 - mask) * background_val    # set background value

This should be differentiable.

@haarburger haarburger added this to the 0.1 Initial Release milestone Dec 12, 2019
@justusschock
Copy link
Member

@haarburger any progress on this? otherwise I would implement this :)

@haarburger
Copy link
Contributor Author

Nope, haven't done anything so far.

@mibaumgartner mibaumgartner removed this from the 0.1 Initial Release milestone Feb 24, 2020
@mibaumgartner mibaumgartner added the GoodFirstPR Issues which are suited as a first PR label May 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FeatureRequest Request for additional feature GoodFirstPR Issues which are suited as a first PR
Projects
None yet
Development

No branches or pull requests

3 participants