Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't mix placeholder and value in issue template #4

Open
spirillen opened this issue Dec 25, 2024 · 0 comments
Open

Don't mix placeholder and value in issue template #4

spirillen opened this issue Dec 25, 2024 · 0 comments
Assignees
@funilrys
Labels
bug Something isn't working

Comments

@spirillen
Copy link
Contributor

Delete all the value's from the issue templates and stick to placeholder, with exceptions for the screenshots, where the preformatted text are beneficial for working with the report. Wrote the same to you in https://github.com/funilrys/PyFunceble.

Placeholder shop the text in a shadowed still in the field, while value are pre-printed text that needs to be marked + deleted before the reporter can type their msg.

.github/.github/ISSUE_TEMPLATE/01-phishing.yml

Lines 55 to 61 in 4974261

value: |
* `example.com`
* `sub.example.com`
* `https://example.com/page`
* `https://sub.example.com/page`
* **NSFW** `example.com`
* `192.168.0.0/16`

@spirillen spirillen added the bug Something isn't working label Dec 25, 2024
@spirillen spirillen changed the title Don't mix plaveholder and value in issue template Don't mix placeholder and value in issue template Dec 25, 2024
spirillen added a commit that referenced this issue Dec 25, 2024
@spirillen
placeholder|value 01-phishing.yml
a191a80 
Related to #4

Signed-off-by: spirillen <[email protected]>
@spirillen spirillen mentioned this issue Dec 25, 2024
Open
spirillen added a commit that referenced this issue Dec 27, 2024
@spirillen
Rewrite of 02-bug.yml
a0b0daa 
With this rewrite, all annoyances have been removed = enhanced the template, as users no longer have to settle with double typing as they had to mark and delete all fields before they could add there contribution. This means we might have and continues to loose reports until this is solved.

This MR also fixing the following issue

Closes #6
Fix #3
Relates to #4

Signed-off-by: spirillen <[email protected]>
@spirillen spirillen mentioned this issue Dec 27, 2024
Open
spirillen added a commit that referenced this issue Dec 27, 2024
@spirillen
formatted 01-phishing.yml
a7709c9 
as in #7, the phishing report is now correctly formatted and optimized for easy to use as intended, when I first created this repository.

This MR will solve #4

Fixing #4

Signed-off-by: spirillen <[email protected]>
spirillen added a commit that referenced this issue Dec 27, 2024
@spirillen
Correctly formatted 00-false-positive.yml
deb3350 

With this rewrite, all annoyances have been removed = enhanced the template, as users no longer have to settle with double typing as they had to mark and delete all fields before they could add there contribution. This means we might have and continues to loose reports until this is solved.

This MR also fixing the following issue

Relates to #3, #4, #6 and #7 


Signed-off-by: spirillen <[email protected]>
@spirillen spirillen mentioned this issue Dec 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@funilrys funilrys

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@funilrys @spirillen