Default MANIFEST.SKIP too aggressive about exclusions [cpan #57507]

[p5pRT]

Migrated from rt.perl.org#122416 (status was 'rejected')

Searchable as RT122416$

[p5pRT]

From @jkeenan

[Since ExtUtils-Manifest is now primarily maintained by Perl 5 Porters, I am moving this ticket here from https://rt.cpan.org/Ticket/Display.html?id=57507. -- jkeenan]

The default MANIFEST.SKIP includes rules like these​:

  # Avoid version control files.
  \bRCS\b
  \bCVS\b
  \bSCCS\b

This erroneously matches input like​:

  lib/Library/CVS.pm
  lib/Library/RCS.pm
  lib/Library/SCCS.pm

Those systems will never produce CVS.pm files, so just checking for \b
is an error.

[p5pRT]

From @jkeenan

Summary of my perl5 (revision 5 version 21 subversion 3) configuration​:
  Commit id​: ce5b0b8
  Platform​:
  osname=linux, osvers=3.13.0-32-generic, archname=x86_64-linux
  uname='linux zareason 3.13.0-32-generic #57-ubuntu smp tue jul 15 03​:51​:08 utc 2014 x86_64 x86_64 x86_64 gnulinux '
  config_args='-des -Dusedevel'
  hint=recommended, useposix=true, d_sigaction=define
  useithreads=undef, usemultiplicity=undef
  use64bitint=define, use64bitall=define, uselongdouble=undef
  usemymalloc=n, bincompat5005=undef
  Compiler​:
  cc='cc', ccflags ='-fwrapv -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64',
  optimize='-O2',
  cppflags='-fwrapv -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include'
  ccversion='', gccversion='4.8.2', gccosandvers=''
  intsize=4, longsize=8, ptrsize=8, doublesize=8, byteorder=12345678
  d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16
  ivtype='long', ivsize=8, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8
  alignbytes=8, prototype=define
  Linker and Libraries​:
  ld='cc', ldflags =' -fstack-protector -L/usr/local/lib'
  libpth=/usr/local/lib /usr/lib/gcc/x86_64-linux-gnu/4.8/include-fixed /usr/include/x86_64-linux-gnu /usr/lib /lib/x86_64-linux-gnu /lib/../lib /usr/lib/x86_64-linux-gnu /usr/lib/../lib /lib
  libs=-lnsl -ldl -lm -lcrypt -lutil -lc
  perllibs=-lnsl -ldl -lm -lcrypt -lutil -lc
  libc=libc-2.19.so, so=so, useshrplib=false, libperl=libperl.a
  gnulibc_version='2.19'
  Dynamic Linking​:
  dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E'
  cccdlflags='-fPIC', lddlflags='-shared -O2 -L/usr/local/lib -fstack-protector'

Characteristics of this binary (from libperl)​:
  Compile-time options​: HAS_TIMES PERLIO_LAYERS PERL_DONT_CREATE_GVSV
  PERL_HASH_FUNC_ONE_AT_A_TIME_HARD PERL_MALLOC_WRAP
  PERL_NEW_COPY_ON_WRITE PERL_PRESERVE_IVUV
  PERL_USE_DEVEL USE_64_BIT_ALL USE_64_BIT_INT
  USE_LARGE_FILES USE_LOCALE USE_LOCALE_COLLATE
  USE_LOCALE_CTYPE USE_LOCALE_NUMERIC USE_LOCALE_TIME
  USE_PERLIO USE_PERL_ATOF
  Built under linux
  Compiled at Jul 27 2014 17​:53​:58
  %ENV​:
  PERL5LIB="/home/jkeenan/perl5/lib/perl5"
  PERLBREW_BASHRC_VERSION="0.67"
  PERLBREW_HOME="/home/jkeenan/.perlbrew"
  PERLBREW_MANPATH="/home/jkeenan/perl5/perlbrew/perls/perl-5.20.0/man"
  PERLBREW_PATH="/home/jkeenan/perl5/perlbrew/bin​:/home/jkeenan/perl5/perlbrew/perls/perl-5.20.0/bin"
  PERLBREW_PERL="perl-5.20.0"
  PERLBREW_ROOT="/home/jkeenan/perl5/perlbrew"
  PERLBREW_VERSION="0.67"
  PERL_LOCAL_LIB_ROOT="/home/jkeenan/perl5"
  PERL_MB_OPT="--install_base "/home/jkeenan/perl5""
  PERL_MM_OPT="INSTALL_BASE=/home/jkeenan/perl5"
  PERL_WORKDIR="gitwork/perl"
  @​INC​:
  lib
  /home/jkeenan/perl5/lib/perl5/x86_64-linux
  /home/jkeenan/perl5/lib/perl5
  /usr/local/lib/perl5/site_perl/5.21.3/x86_64-linux
  /usr/local/lib/perl5/site_perl/5.21.3
  /usr/local/lib/perl5/5.21.3/x86_64-linux
  /usr/local/lib/perl5/5.21.3
  .

[p5pRT]

From @jkeenan

The default MANIFEST.SKIP includes rules like these​:

# Avoid version control files.
\bRCS\b
\bCVS\b
\bSCCS\b

This erroneously matches input like​:

lib/Library/CVS.pm
lib/Library/RCS.pm
lib/Library/SCCS.pm

Those systems will never produce CVS.pm files, so just checking for \b
is an error.

Avar (or anyone),

Can you suggest a more tightly defined pattern?

Thank you very much.
Jim Keenan

[p5pRT]

The RT System itself - Status changed from 'new' to 'open'

[p5pRT]

From @avar

If it's checked per-dir then e.g. /\ACVS\z/, otherwise
/(?​:${pathsep})?CVS\z/ should do.

Anyway I just filed this bug a long time ago as a "look what I found"
because I had a CVS.pm file. IIRC this was for Crypt​::CVS.
On 27 Jul 2014 23​:26, "James E Keenan via RT" <perlbug-followup@​perl.org>
wrote​:

The default MANIFEST.SKIP includes rules like these​:

# Avoid version control files.
\bRCS\b
\bCVS\b
\bSCCS\b

This erroneously matches input like​:

lib/Library/CVS.pm
lib/Library/RCS.pm
lib/Library/SCCS.pm

Those systems will never produce CVS.pm files, so just checking for \b
is an error.

Avar (or anyone),

Can you suggest a more tightly defined pattern?

Thank you very much.
Jim Keenan

[p5pRT]

From @jkeenan

Since it was subsequently resolved that ExtUtils-Manifest would be maintained outside of core by PerlToolchainGang, and since these issues are referenced at​: Perl-Toolchain-Gang/ExtUtils-Manifest#1, I am closing this rt.perl.org ticket.

--
James E Keenan (jkeenan@​cpan.org)

[p5pRT]

@jkeenan - Status changed from 'open' to 'rejected'