Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RT-78269 one-line fix for `use 5.010' #25

Open
kevindawson opened this issue Mar 25, 2014 · 1 comment
Open

RT-78269 one-line fix for `use 5.010' #25

kevindawson opened this issue Mar 25, 2014 · 1 comment

Comments

@kevindawson
Copy link
Member

It appears that %Module::CoreList::version has perl 5.10 listed as 5.01 rather than 5.010. This patch just enforces the six-digit decimal perl version for versions greater than or equal to 5.006.
Subject: djt-module-install.diff
Download djt-module-install.diff
text/x-diff 571b

Index: lib/Module/Install/Admin/ScanDeps.pm =================================================================== --- lib/Module/Install/Admin/ScanDeps.pm (revision 15456)
+++ lib/Module/Install/Admin/ScanDeps.pm (working copy)
@@ -18,6 +18,8 @@
    perl_version('5.005');
  END_MESSAGE
    $perl_version =~ s{^(\d+)\.(\d+)\.(\d+)}{$1 + $2/1_000 + $3/1_000_000}e;
+ # make this more robust against situations like 5.01/5.010
+ $perl_version = sprintf('%0.6f', $perl_version) if $perl_version >= 5.006;

require Module::ScanDeps;
require Module::CoreList; 
@kevindawson
Copy link
Member Author

If this has already been addressed in Module::CoreList can we not just bump M::I requirments in Makefile.PL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant