Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: 1.68 breaks Makefile.PL in distributions with symbolic links #6

Open
eserte opened this issue Sep 23, 2014 · 6 comments
Open
Assignees

Comments

@eserte
Copy link

eserte commented Sep 23, 2014

See #5 (comment)

@karenetheridge karenetheridge self-assigned this Feb 2, 2015
@sni
Copy link

sni commented Jul 21, 2020

any news on this?

@karenetheridge
Copy link
Member

If you have symlinks in your distribution, the best advice is "don't", because they are treated differently across different architectures (or not at all).

@sni
Copy link

sni commented Jul 22, 2020

thing is, it worked pretty well up to version 1.68 and i have to install this specific version ever since. Can i assume this regression wont be fixed at all? Then i have to find another solution instead of waiting for a fix.

@karenetheridge
Copy link
Member

What exactly is the problem you're having? Is there a public distribution or repository that can be examined?

@sni
Copy link

sni commented Jul 23, 2020

My project ships with symlinks for toggable plugins and themes. It can be easily reproduced with:

prepare:

%> cd /tmp
%> git clone --depth=1 https://github.com/sni/Thruk.git
%> cd Thruk
%> perl Makefile.PL
%> make manifest
/usr/bin/perl" "-Iinc" "-MExtUtils::Manifest=mkmanifest" -e mkmanifest
/tmp/Thruk/themes/themes-available/Wakizashi/stylesheets/splashpage.css is encountered a second time at /usr/share/perl/5.30/File/Find.pm line 79.
make: *** [Makefile:932: manifest] Error 255

resulting in an empty MANIFEST file.

my workaround till now is simply installing an old version:

%> cpanm -n http://search.cpan.org/CPAN/authors/id/F/FL/FLORA/ExtUtils-Manifest-1.63.tar.gz

which works well and simply adds the symbolic links to the manifest file.

@eserte
Copy link
Author

eserte commented May 22, 2022

If you have symlinks in your distribution, the best advice is "don't", because they are treated differently across different architectures (or not at all).

The error even happens if the author does not intend to use the symlinks in a resulting tarball at all (i.e. by using appropriate MANIFEST.SKIP lines).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants