prevent PPI::Normal->register from registering duplicates

wchristian · wchristian · commit addc11f696be · 2016-12-04T21:01:45.000+01:00
diff --git a/lib/PPI/Normal.pm b/lib/PPI/Normal.pm
@@ -86,7 +86,7 @@ sub register {
 		}
 
 		# Has it already been added?
-		if ( List::Util::any { $_ eq $function } ) {
+		if ( List::Util::any { $_ eq $function } map @{$_}, values %LAYER ) {
 			return 1;
 		}
 
diff --git a/t/09_normal.t b/t/09_normal.t
@@ -58,6 +58,5 @@ NO_DOUBLE_REG: {
 	is $PPI::Normal::LAYER{2}[-1], "main::just_a_test_sub", "and find subs at right layer";
 	my $size = @{ $PPI::Normal::LAYER{2} };
 	ok( PPI::Normal->register( "main::just_a_test_sub", 2 ), "can add subs again" );
-	local $TODO = 'prevent duplicate registrations of normals';
 	is scalar @{ $PPI::Normal::LAYER{2} }, $size, "but sub isn't added twice";
 }

Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,7 @@ sub register {`
`86`	`86`	`}`
`87`	`87`
`88`	`88`	`# Has it already been added?`
`89`		`- if ( List::Util::any { $_ eq $function } ) {`
	`89`	`+ if ( List::Util::any { $_ eq $function } map @{$_}, values %LAYER ) {`
`90`	`90`	`return 1;`
`91`	`91`	`}`
`92`	`92`
Original file line number	Diff line number	Diff line change
`@@ -58,6 +58,5 @@ NO_DOUBLE_REG: {`
`58`	`58`	`is $PPI::Normal::LAYER{2}[-1], "main::just_a_test_sub", "and find subs at right layer";`
`59`	`59`	`my $size = @{ $PPI::Normal::LAYER{2} };`
`60`	`60`	`ok( PPI::Normal->register( "main::just_a_test_sub", 2 ), "can add subs again" );`
`61`		`- local $TODO = 'prevent duplicate registrations of normals';`
`62`	`61`	`is scalar @{ $PPI::Normal::LAYER{2} }, $size, "but sub isn't added twice";`
`63`	`62`	`}`