Make related code compilable with frontend #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dAdAbird
force-pushed
the
frontend_tools
branch
2 times, most recently
from
9bb0394
to
4602fbf
Compare
dAdAbird
force-pushed
the
frontend_tools
branch
from
4602fbf
to
4019dd1
Compare
This commit makes the code around keyring, principal keys and WAL encryption compilable with frontend tools. Namely: - Hide everything that isn't compatible and of no use behind '#ifndef FRONTEND' - Redefine code that is needed in both versions but should have different code. E.g. error handling, file descriptors and locks - Make use of frontend lists instead of backend ones where needed. For https://perconadev.atlassian.net/browse/PG-857
... and all the things work with pg_waldump
dAdAbird
force-pushed
the
frontend_tools
branch
from
d333448
to
9828734
Compare
codeforall
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes the code around keyring, principal keys and WAL encryption compilable with frontend tools. Namely:
For PG-857