Heap clone refactoring / cleanup #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dutow
force-pushed
the
pg16move
branch
2 times, most recently
from
0a7ec76
to
9405aaa
Compare
dAdAbird
reviewed
Aug 7, 2024
src/storage/read_stream.h
Outdated
| @@ -0,0 +1,73 @@ | |||
| /*------------------------------------------------------------------------- | |||
There was a problem hiding this comment.
Does this have to be here? Looks like a dup of include/storage/read_stream.h
src/include/storage/read_stream.h
Outdated
| @@ -0,0 +1,73 @@ | |||
| /*------------------------------------------------------------------------- | |||
There was a problem hiding this comment.
I don't see any usage of this header file anywhere in the code. Is this something for the future?
Merged
This commit just removed old no longer needed comments, and fixes a few inconsistent naming issues so the diff between upstream and our code is minimal (after running the sed script to process upstream code)
Recent commits in the PG17 code added additional API changes, making the "single src directory with ifdefs" approach inpractical. This commit adds a new python based script (documented with comments in the file) to help with version specific merges, where the copied heap files reside in srcXX directories, where XX is the version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests adds a new helper script, and moves our modified heap AM from the "src" to the "src16" directory.
It also contains more cleanup (removal of old no longer needed comments/changes, and fixing of a missing previous heap commit).
As these are multiple, but related changes the pull request contains multiple commits. Instead of reviewing it all together please review the individual commit messages and review the commits one by one, as that makes more sense in this case, but I don't one to split it into even more pull requests.