Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]-Cisco Spark Codec doesn't bridge 'Directory Search Busy FB' #950

Open
ngenovese11 opened this issue Jun 8, 2022 · 2 comments
Open
Labels
bug Something isn't working planning

Comments

@ngenovese11
Copy link
Contributor

Was this bug identified in a specific build version?
1.10.1

Describe the bug
No feedback comes through on Digital Join 100 - 'Directory Search Busy FB'

Expected behavior
Digital Join 100 to go high while a search is busy

@ngenovese11 ngenovese11 added the bug Something isn't working label Jun 8, 2022
@ndorin
Copy link
Contributor

ndorin commented Jun 8, 2022

Investigation revealed that DirectorySearchBusy in VideoCodecControllerJoinMap is not referenced anywhere.

To resolve, I would suggest adding a BoolFeedback to the IHasDirectory interface called SearchInProgressFB or similar. This would then necessitate implementation on CiscoSparkCodec and ZoomRoom likely by setting the FB value high when the SearchDirectory method is called and then low when the DirectoryResultReturned event fires.

There's probably some other ways to tackle it, but that's what first comes to mind.

@ndorin
Copy link
Contributor

ndorin commented Jun 8, 2022

This matters most on the CiscoSparkCodec class since it actually uses the codec API to perform a search using on the device. With ZoomRoom we get the entire phonebook when we initially sync with the device and the searching happens in local memory, which is pretty fast.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working planning
Projects
None yet
Development

No branches or pull requests

3 participants