Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better vertical CTM control for glass panes #295

Open
muzikbike opened this issue Aug 6, 2023 · 1 comment
Open

Better vertical CTM control for glass panes #295

muzikbike opened this issue Aug 6, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@muzikbike
Copy link

This arrangement of glass panes:
2023-08-06_01 44 47

looks like this with CTM enabled:
2023-08-06_01 44 34

There's a nice continuous border around the edges of the glass for the most part, but it terminates at two points.
doctored

The blue border is probably very easy to fix with model files alone and specific CTM for this texture (I myself have fixed this in a non-CTM context by redoing the models), but the red line would require that the pane should not only detect the presence of a glass pane above or below it, but also its connection type. To my knowledge, the mod does not currently allow for this.

Even OptiFine, with its #74 fix, is not immune to this problem, with textures connecting in sub-block places where they really should not:
2023-08-06_02 00 50

I don't really know how complicated a fix for this would be, but it's something I'd like to see quite a lot since a fix for it and #74 would allow for absolutely perfect glass pane connections.

@muzikbike
Copy link
Author

I believe this is the issue that sp614x/optifine#193 describes.

I've managed to seamlessly fix the blue border (#301), so red is the remaining one. We'd need panes to be able to accept separate "up_left", "up_right", "down_left" and "down_right" connections, rather than just "up" and "down". For higher resolution resource packs, "up_center" and "down_center" may also be relevant but I don't personally plan on using these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants