Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail Gulp task if PowerShell scripts fail #8

Open
uli-weltersbach opened this issue Jul 14, 2017 · 1 comment
Open

Fail Gulp task if PowerShell scripts fail #8

uli-weltersbach opened this issue Jul 14, 2017 · 1 comment
Labels
Milestone

Comments

@uli-weltersbach
Copy link

uli-weltersbach commented Jul 14, 2017

When a Gulp-task calls a PowerShell script, ensure a non-zero exit code causes the Gulp-script to fail.

E.g. Install-Packages.ps1:

foreach ($package in $packages.packages) {
    Install-NugetPackage -package $package -webRootPath $webRootPath -dataRootPath $dataRootPath -username $username -password $password
}

Gulp will return an exit code of zero even when one of the Install-NugetPackage-calls fails, the user doesn't have administrative privileges to run the script etc.

@uli-weltersbach uli-weltersbach changed the title Return non-zero exit code from failing PowerShell scripts Fail Gulp task if PowerShell scripts fails Jul 14, 2017
@uli-weltersbach uli-weltersbach changed the title Fail Gulp task if PowerShell scripts fails Fail Gulp task if PowerShell scripts fail Jul 14, 2017
@Hafeok Hafeok added the bug label Jul 18, 2017
@Hafeok Hafeok modified the milestone: V 1.0.0 Jul 18, 2017
@melker
Copy link

melker commented Jan 17, 2018

If the task had returned a proper error code it would have saved me 2 full days of work looking for all kinds of other errors. :-(
Please fix @Hafeok so others don't have to do the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants