Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make mapping of cell type assignment to cell type factor more flexible #1306

Closed
2 of 3 tasks
arteymix opened this issue Dec 18, 2024 · 2 comments
Closed
2 of 3 tasks

Make mapping of cell type assignment to cell type factor more flexible #1306

arteymix opened this issue Dec 18, 2024 · 2 comments
Assignees
@arteymix
Labels
cli Issues affecting the CLI enhancement Enhance the code or user experience low priority single cell Issues related to single-cell data support

Comments

@arteymix
Copy link
Member

arteymix commented Dec 18, 2024 •
edited
Loading

At this moment, these two must match exactly when aggregating with corresponding characteristics.
@arteymix arteymix added enhancement Enhance the code or user experience low priority cli Issues affecting the CLI single cell Issues related to single-cell data support labels Dec 18, 2024
arteymix added a commit that referenced this issue Dec 19, 2024
@arteymix
Allow aggregating single-cell data when a factor value is missing
bea9e07 
For CLI tools, always allow this.

This is part of #1306.

Refactor SingleCellExpressionExperimentAggregatorServiceImpl into more
private methods.
@arteymix
Copy link
Member Author

Now that we can deal with missing or deleted factors, I'll put this on hold.

@arteymix arteymix self-assigned this Dec 19, 2024
@arteymix
Copy link
Member Author

Fixed in d05ed77

We can implement custom mapping strategies now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arteymix arteymix

Labels
cli Issues affecting the CLI enhancement Enhance the code or user experience low priority single cell Issues related to single-cell data support
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@arteymix