Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gist-unit-test #103

Closed
PaulieScanlon opened this issue Sep 20, 2020 · 1 comment · Fixed by #184
Closed

gist-unit-test #103

PaulieScanlon opened this issue Sep 20, 2020 · 1 comment · Fixed by #184
Assignees
@PaulieScanlon
Labels
good first issue Good for newcomers hacktoberfest Open source is changing the world - one pull request at a time hacktoberfest-accepted Open source is changing the world - one pull request at a time
Milestone
Stable Release | ...

Comments

@PaulieScanlon
Copy link
Owner

Hooray 🎉 thanks for your interest in MDX Embed

If you'd like to contribute by writing this test please have a read of:
@PaulieScanlon PaulieScanlon added the hacktoberfest Open source is changing the world - one pull request at a time label Sep 20, 2020
@PaulieScanlon PaulieScanlon added this to the v1.0.0 milestone Sep 23, 2020
@remiroyc remiroyc mentioned this issue Sep 24, 2020
Closed
53 tasks
@PaulieScanlon PaulieScanlon added hacktoberfest-accepted Open source is changing the world - one pull request at a time good first issue Good for newcomers labels Oct 12, 2020
@PaulieScanlon PaulieScanlon linked a pull request Oct 16, 2020 that will close this issue
Add integration and unit test for gist component - Closes #103 #104 #184
Merged
@PaulieScanlon PaulieScanlon reopened this Oct 30, 2020
@PaulieScanlon PaulieScanlon self-assigned this Oct 30, 2020
@PaulieScanlon
Copy link
Owner Author

There's a useEffect in this component that calls createScriptTag and createStyleSheet and sets setGistResponse hook. These could use some love.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PaulieScanlon PaulieScanlon

Labels
good first issue Good for newcomers hacktoberfest Open source is changing the world - one pull request at a time hacktoberfest-accepted Open source is changing the world - one pull request at a time
Projects
None yet
Milestone
Stable Release | 1.0.0
Development

Successfully merging a pull request may close this issue.

Add integration and unit test for gist component - Closes #103 #104 matiasfha/mdx-embed
1 participant
@PaulieScanlon