Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage #93

Open
PaulMcInnis opened this issue Sep 12, 2020 · 5 comments
Open

Improve test coverage #93

PaulMcInnis opened this issue Sep 12, 2020 · 5 comments

Comments

@PaulMcInnis
Copy link
Owner

PaulMcInnis commented Sep 12, 2020

Description

A cost of releasing version 3.0.0 is a signifcant loss of test coverage.

Steps to Reproduce

git clone https://github.com/PaulMcInnis/JobFunnel
cd JobFunnel
pytest

Expected behavior

We should cover Jobfunnel and scraper get/set methods with unit testing via pyest. Existing codecov was set to around 60%

Coverage

I've added Notes for all the modules that need testing coverage in a kanban here: https://github.com/PaulMcInnis/JobFunnel/projects/2

Please keep this up-to-date so that we don't duplicate eachother's work on upping the test coverage 👍

@thebigG thebigG self-assigned this Sep 12, 2020
@PaulMcInnis PaulMcInnis changed the title Improve Test coverage Improve test coverage Sep 12, 2020
@thebigG
Copy link
Collaborator

thebigG commented Sep 12, 2020

Now that we have a solid foundation to test on, I'll start testing. Thanks for organizing the testing suite, it looks very neat now 👍

Looked at the new readme and I'm wondering why there isn't instructions for developers to install JobFunnel in-palce like we had before?

@PaulMcInnis
Copy link
Owner Author

Just decided it was not necessesary, since that information is common to all python packages, available as pipe install -e

@PaulMcInnis
Copy link
Owner Author

In general I've stripped down the readme a lot in the interest of keeping it very simple for a new user to understand vs providing extra information, even if it's kinda useful like the in-place command

@thebigG
Copy link
Collaborator

thebigG commented Sep 12, 2020

That makes sense. A long readme can be intimidating for users who just want to use the tool.

@PaulMcInnis
Copy link
Owner Author

PaulMcInnis commented Sep 13, 2020

I'll leave this tagged help-wanted, jic others want to help out as well. I'll help with this as well after I get do 3.0.1 milestone.

I've added a kanban (todo/inprogress/done) thing over here so we can keep track of what people are working on so we dont duplicate eachother's work: https://github.com/PaulMcInnis/JobFunnel/projects/2

@PaulMcInnis PaulMcInnis added this to the 4.0 milestone Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants