Skip to content

Commit 0e656c7

Browse files
authored
When clicking on dismiss button stopping click propagation (#421)
1 parent 63b25f7 commit 0e656c7

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

src/ServicePulse.Host/app/js/views/failed_groups/controller.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,13 +39,14 @@
3939
$location.path('/failed-messages/groups/' + group.id);
4040
};
4141

42-
vm.acknowledgeGroup = function (group) {
42+
vm.acknowledgeGroup = function (group, $event) {
4343
serviceControlService.acknowledgeGroup(group.id,
4444
'Group Acknowledged',
4545
'Acknowledging Group Failed')
4646
.then(function(message) {
4747
vm.exceptionGroups.splice(vm.exceptionGroups.indexOf(group), 1);
48-
});
48+
});
49+
$event.stopPropagation();
4950
}
5051

5152
vm.archiveExceptionGroup = function(group) {

src/ServicePulse.Host/app/js/views/failed_groups/view.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ <h6>Failed message groups</h6>
151151
</li>
152152
<li ng-show="group.workflow_state.status === 'completed'">
153153
<div class="retry-completed bulk-retry-progress-status">Retry request completed</div>
154-
<button type="button" class="btn btn-default btn-primary btn-xs btn-retry-dismiss" ng-show="group.need_user_acknowledgement == true" ng-click="vm.acknowledgeGroup(group)">
154+
<button type="button" class="btn btn-default btn-primary btn-xs btn-retry-dismiss" ng-show="group.need_user_acknowledgement == true" ng-click="vm.acknowledgeGroup(group, $event)">
155155
Dismiss
156156
</button>
157157
<div class="danger sc-restart-warning" ng-show="{{group.workflow_state.failed}}">

0 commit comments

Comments
 (0)