Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pets can be bapped with a "rolled up" newspaper that wasn't rolled up #24413

Open
1 task done
FunnyMan3595 opened this issue Mar 3, 2024 · 0 comments · May be fixed by #26112
Open
1 task done

Pets can be bapped with a "rolled up" newspaper that wasn't rolled up #24413

FunnyMan3595 opened this issue Mar 3, 2024 · 0 comments · May be fixed by #26112
Labels
Good First Issue This issue is easily fixable and could be worth handing to a new contributor Oversight This was forgotten about

Comments

@FunnyMan3595
Copy link
Contributor

Exploit Reports

  • I confirm this issue is not an exploit. (Required)

BYOND Version

515.1623

Issue Description

Pets can be bapped with a "rolled up" newspaper that wasn't rolled up

What did you expect to happen?

If the newspaper isn't rolled up, no bapping.

What happened instead?

Bapping was had.

Why is this bad/What are the consequences?

It's inconsistent with the displayed text.

Steps to reproduce the issue.

  1. Spawn as HoP.
  2. Print out a newspaper at a newscaster.
  3. Take the newspaper.
  4. Bap Ian with the newspaper.
  5. What do you mean it was rolled up?

When did the problem start happening?

Unknown

Extra information

Code is here:

Paradise/code/modules/mob/living/simple_animal/friendly/pet.dm

Line 9 in 7ae3bf6

/mob/living/simple_animal/pet/attackby(obj/item/O, mob/user, params)

Relevant log output/runtime error

No response
@Henri215 Henri215 added Oversight This was forgotten about Good First Issue This issue is easily fixable and could be worth handing to a new contributor labels Mar 3, 2024
Peterrrrrrrr added a commit to Peterrrrrrrr/Paradise that referenced this issue May 31, 2024
@Peterrrrrrrr
Fix for ParadiseSS13#24413
4d61bdc 
none rolled up newspapers cannot be used to bap Ian anymore
@EmeraldCandy EmeraldCandy linked a pull request Jul 2, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue This issue is easily fixable and could be worth handing to a new contributor Oversight This was forgotten about
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Newspaper bap fix EmeraldCandy/Paradise
2 participants
@FunnyMan3595 @Henri215