Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Proc For Telling You Who Shoved Who Into an Object Doesn't Work With Vendors #26072

Closed
1 task done
Fordoxia opened this issue Jun 28, 2024 · 0 comments · Fixed by #26108
Closed
1 task done

The Proc For Telling You Who Shoved Who Into an Object Doesn't Work With Vendors #26072

Fordoxia opened this issue Jun 28, 2024 · 0 comments · Fixed by #26108
Labels
Bug This is a bug in our game code oops We all make mistakes

Comments

@Fordoxia
Copy link
Contributor

Exploit Reports

  • I confirm this issue is not an exploit. (Required)

BYOND Version

515.1633

Issue Description

When you shove someone into a table or wall, you get told by /datum/species/proc/disarm in species.dm. This doesn't function when vendorshoving someone.

What did you expect to happen?

To be told who did a vendorshove.

What happened instead?

I am only told that the victim has been crushed.

Why is this bad/What are the consequences?

In crowded areas, ESPECIALLY during the late arrival station trait, it is impossible to identify who did a vendorshove based on the chat. It also happens a lot during said station trait.

Steps to reproduce the issue.

Shove someone into vendor.

When did the problem start happening?

God knows.

Extra information

No response

Relevant log output/runtime error

No response
@lewcc lewcc added Bug This is a bug in our game code oops We all make mistakes labels Jul 2, 2024
Spaghetti-bit added a commit to Spaghetti-bit/Paradise-LazarusReagentChange that referenced this issue Jul 2, 2024
@Spaghetti-bit
Fixes ParadiseSS13#26072
16a138f
@Spaghetti-bit Spaghetti-bit mentioned this issue Jul 2, 2024
Merged
@Spaghetti-bit Spaghetti-bit added Oversight This was forgotten about and removed Oversight This was forgotten about labels Jul 2, 2024
github-merge-queue bot pushed a commit that referenced this issue Jul 3, 2024
@Spaghetti-bit @Fordoxia @lewcc
Shoving someone into a vendor now informs people around them. (#26108)
06a52c5 
* Fixes #26072

* Apply suggestions from code review

Co-authored-by: CRUNCH <[email protected]>
Co-authored-by: Luc <[email protected]>
Signed-off-by: Spaghetti-bit <[email protected]>

* Applies suggestions.

---------

Signed-off-by: Spaghetti-bit <[email protected]>
Co-authored-by: CRUNCH <[email protected]>
Co-authored-by: Luc <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug This is a bug in our game code oops We all make mistakes
Projects
None yet
Milestone
No milestone
3 participants
@Spaghetti-bit @lewcc @Fordoxia