Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin injector is in DEVELOPMENT stage #539

Open
dentmaged opened this issue Jul 10, 2021 · 1 comment
Open

Plugin injector is in DEVELOPMENT stage #539

dentmaged opened this issue Jul 10, 2021 · 1 comment
Labels
type: feature New feature or request

Comments

@dentmaged
Copy link

Since JavaPluginLoader#createPlugin doesn't provide a stage when creating the injector, it defaults to DEVELOPMENT (see the guice docs).

I think it should default to PRODUCTION and should be a command line or configuration option. The stage is important as it affects how singletons are initialised.
@astei astei added the type: feature New feature or request label Jul 10, 2021
@astei
Copy link
Contributor

astei commented Jul 10, 2021

Considering this behavior stretches back to Velocity 1.0.0, I'm not sure this qualifies as a bug. Changing this now would be a backwards-incompatible change that would have to wait for Polymer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dentmaged @astei