Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancelling PlayerCommandPreprocessEvent causes "missing or invalid chat signature" #9961

Closed
RhythmicSys opened this issue Nov 22, 2023 · 1 comment
Labels
status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added. type: bug Something doesn't work as it was intended to. upstream: bukkit Issues exists in Bukkit and/or CraftBukkit. upstream: spigot Issues exists in Spigot.

Comments

@RhythmicSys
Copy link

Expected behavior

Cancelling a player's command would cancel the command being run
The player would be able to chat as intended

Observed/Actual behavior

After a player's command is cancelled, they cannot chat or run another command without being kicked.

Steps/models to reproduce

A simple plugin with a class that contains this code:

public class CommandListener implements Listener {
    @EventHandler
    public void onCommand(PlayerCommandPreprocessEvent event) {
        event.setCancelled(true);
    }
}

Will cause this situation:

2023-11-22_13-39-35.mp4

Plugin and Datapack List

[13:56:55 INFO]: Server Plugins (1):
[13:56:55 INFO]: Paper Plugins:
[13:56:55 INFO]:  - CommandTest
[13:57:36 INFO]: There are 2 data pack(s) enabled: [vanilla (built-in)], [file/bukkit (world)]
[13:57:36 INFO]: There are no more data packs available

Paper version

[13:58:02 INFO]: This server is running Paper version git-Paper-298 (MC: 1.20.2) (Implementing API version 1.20.2-R0.1-SNAPSHOT) (Git: e1cd9e5)
You are running the latest version

Other

No response

@RhythmicSys RhythmicSys added status: needs triage type: bug Something doesn't work as it was intended to. labels Nov 22, 2023
@papermc-projects papermc-projects bot moved this to 🕑 Needs Triage in Issues: Bugs Nov 22, 2023
@electronicboy electronicboy added upstream status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added. upstream: spigot Issues exists in Spigot. upstream: bukkit Issues exists in Bukkit and/or CraftBukkit. and removed status: needs triage labels Nov 23, 2023
@papermc-projects papermc-projects bot moved this from 🕑 Needs Triage to ✅ Accepted in Issues: Bugs Nov 23, 2023
@kashike kashike removed the upstream label Apr 28, 2024
@Warriorrrr
Copy link
Member

Unable to reproduce now in 1.21.4 with the given reproduction code + video, I'm able to repeatedly use /me test and still chat/run commands fine after

@Warriorrrr Warriorrrr closed this as not planned Won't fix, can't repro, duplicate, stale Dec 27, 2024
@github-project-automation github-project-automation bot moved this from ✅ Accepted to Done in Issues: Bugs Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added. type: bug Something doesn't work as it was intended to. upstream: bukkit Issues exists in Bukkit and/or CraftBukkit. upstream: spigot Issues exists in Spigot.
Projects
Status: Done
Development

No branches or pull requests

4 participants