skip-vanilla-damage-tick-when-shield-blocked option removes block sound when enabled

[LaserSlime]

Expected behavior

When a player blocks their shield and another player hits it, the blocking player should hear a block sound in addition to a "weak attack" sound.

Observed/Actual behavior

The block sound does not play, instead only the "weak attack" sound plays.

Steps/models to reproduce

1. Enable the skip-vanilla-damage-tick-when-shield-blocked option in paper-global.yml and start the server
2. Join with 2 accounts and give one of them a shield and mute the audio on the other one
3. Block your shield with said account (you can pause the game while blocking to continue blocking)
4. Hit against the shield with the other account
5. No block sound plays, only "weak attack"

Plugin and Datapack List

[18:13:53 INFO]: Server Plugins (0):

Paper version

[18:13:51 INFO]: Checking version, please wait...
[18:13:51 INFO]: This server is running Paper version 1.21.3-81-master@da71382 (2024-12-03T14:58:13Z) (Implementing API version 1.21.3-R0.1-SNAPSHOT)
You are running the latest version

Other

This did not happen on Paper 1.21.1.

[electronicboy]

.3 is no longer going to see any fixes, can you reproduce this on .4?

[LaserSlime]

Already? Dang.
But sure I'll try.

[LaserSlime]

Ok it's still reproduceable on 1.21.4.

[lynxplay]

This does not look like it'll be easily fixed given the bug that is skipping vanilla damage ticks that is re-enabled via this option means we just early opt out of any follow up logic.

That is why this option is in the unsupported block.
Obviously open to more input from the team, but to me the fix does not look simple enough to warrant its implementation for something as unsupported as adding back a spigot introduced bug that spigot itself already fixed