Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TrialSpawnerConfig Registry #11722

Open
Machine-Maker opened this issue Dec 8, 2024 · 1 comment
Open

TrialSpawnerConfig Registry #11722

Machine-Maker opened this issue Dec 8, 2024 · 1 comment
Labels
status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added.

Comments

@Machine-Maker
Copy link
Member

Is your feature request related to a problem?

Upstream's TrialSpawnerConfiguration is poorly designed and thought out. It should be a registry-related type that is immutable. The current design makes it impossible to store a registered config without serializing the whole thing to the trial spawner instead of just the reference key.

Describe the solution you'd like.

We should just deprecate that type and associated API for a new immutable type with registry entry builders for modification.

Describe alternatives you've considered.

N/A

Other

No response

@Machine-Maker Machine-Maker added the status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added. label Dec 8, 2024
@lynxplay
Copy link
Contributor

lynxplay commented Dec 8, 2024

Will also resolve #11026 once fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added.
Projects
None yet
Development

No branches or pull requests

2 participants