Call PlayerItemDamageEvent for tridents #11716
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennytv
approved these changes
Dec 7, 2024
|
Shouldn't this then mimic the behavior of #11555 where it's not called for non-positive damage. Then smth else needs to be added for "durability change" or something. |
lynxplay
force-pushed
the
call-pide-trident
branch
from
c3270c5 to
d621254
Compare
|
We should probably allow the item to break if the damage was changed using the API. Will look at that when i come home |
notTamion
force-pushed
the
call-pide-trident
branch
2 times, most recently
from
04e4b97 to
9708554
Compare
notTamion
force-pushed
the
call-pide-trident
branch
from
9708554 to
09f26f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #11655
It also previously wasn't being called for the trident being thrown