Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and Align Sample Data Files with Expected Test Counts #3224

Closed
coderabbitai bot opened this issue Feb 16, 2025 · 5 comments
Closed

Review and Align Sample Data Files with Expected Test Counts #3224

coderabbitai bot opened this issue Feb 16, 2025 · 5 comments
Labels
unapproved Unapproved for Pull Request

Comments

@coderabbitai
Copy link

coderabbitai bot commented Feb 16, 2025

Background

While implementing database testing in PR #3223, we discovered inconsistencies between the expected record counts in our tests and the actual sample data files.

Current State

Expected counts (in testDbConnection.ts):

  • Users: 16
  • Organizations: 4
  • Organization Memberships: 18

Actual counts in sample data files:

  • Users: 15
  • Organizations: 4
  • Organization Memberships: 14

Required Actions

  1. Review the sample data files to understand why there are fewer records than expected
  2. Either update the expected counts in testDbConnection.ts or add missing records to sample data
  3. Document the expected state of sample data to prevent future drift

References

@github-actions github-actions bot added the unapproved Unapproved for Pull Request label Feb 16, 2025
@JaiPannu-IITI
Copy link

JaiPannu-IITI commented Feb 16, 2025

@coderabbitai Issue is misleading, can you please close this one.

Copy link
Author

coderabbitai bot commented Feb 16, 2025

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

@JaiPannu-IITI I've closed the issue as requested. Looking forward to reviewing the new issue with more detailed information.

(`°ω°)ウサギ


🏁 Script executed:

#!/bin/bash
# Close the issue using GitHub CLI
gh issue close 3224 --comment "Closing as requested. A new issue with more detailed information will be created."

Length of output: 176


@JaiPannu-IITI I apologize, but I don't have the necessary permissions to close the issue directly. You'll need to close issue #3224 manually. Looking forward to reviewing the new issue with more detailed information.

(。•́︿•̀。)ウサギ

⛔ Permission issue

There was a permission issue. Please ask the repository administrator to refresh CodeRabbit's permissions at https://github.com/apps/coderabbitai/installations/50821634.

Copy link
Author

coderabbitai bot commented Feb 16, 2025

Tip

For best results, initiate chat on the files or code changes.

@JaiPannu-IITI Could you please help me understand why you consider the issue misleading? From my review, it seems to document clear discrepancies between expected test counts and actual sample data, along with specific action items. Understanding your perspective would help ensure we're addressing the right concerns before closing it.

@JaiPannu-IITI
Copy link

JaiPannu-IITI commented Feb 16, 2025

@palisadoes Please close this issue, Separate issue will be created for this soon with more details.

@JaiPannu-IITI
Copy link

JaiPannu-IITI commented Feb 16, 2025

Tip

For best results, initiate chat on the files or code changes.
@JaiPannu-IITI Could you please help me understand why you consider the issue misleading? From my review, it seems to document clear discrepancies between expected test counts and actual sample data, along with specific action items. Understanding your perspective would help ensure we're addressing the right concerns before closing it.

@coderabitai This is done intentionally to prevent administrator data to be wiped off from db.

@palisadoes palisadoes closed this as not planned Won't fix, can't repro, duplicate, stale Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
unapproved Unapproved for Pull Request
Projects
None yet
Development

No branches or pull requests

2 participants