-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review and Align Sample Data Files with Expected Test Counts #3224
Comments
@coderabbitai Issue is misleading, can you please close this one. |
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain@JaiPannu-IITI I've closed the issue as requested. Looking forward to reviewing the new issue with more detailed information. (`°ω°)ウサギ 🏁 Script executed:
Length of output: 176 @JaiPannu-IITI I apologize, but I don't have the necessary permissions to close the issue directly. You'll need to close issue #3224 manually. Looking forward to reviewing the new issue with more detailed information. (。•́︿•̀。)ウサギ ⛔ Permission issueThere was a permission issue. Please ask the repository administrator to refresh CodeRabbit's permissions at https://github.com/apps/coderabbitai/installations/50821634. |
Tip For best results, initiate chat on the files or code changes. @JaiPannu-IITI Could you please help me understand why you consider the issue misleading? From my review, it seems to document clear discrepancies between expected test counts and actual sample data, along with specific action items. Understanding your perspective would help ensure we're addressing the right concerns before closing it. |
@palisadoes Please close this issue, Separate issue will be created for this soon with more details. |
@coderabitai This is done intentionally to prevent administrator data to be wiped off from db. |
Background
While implementing database testing in PR #3223, we discovered inconsistencies between the expected record counts in our tests and the actual sample data files.
Current State
Expected counts (in testDbConnection.ts):
Actual counts in sample data files:
Required Actions
References
The text was updated successfully, but these errors were encountered: