Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chapter 5: Bookmark Toolbar Not Appearing #86

Open
devMunyi opened this issue May 30, 2021 · 3 comments
Open

Chapter 5: Bookmark Toolbar Not Appearing #86

devMunyi opened this issue May 30, 2021 · 3 comments

Comments

@devMunyi
Copy link

devMunyi commented May 30, 2021 •
edited

In my case I Bookmark toolbar doesn't appear. I have counter checked my code severally, but can't trace where is the problem. Please someone help me fix. On checking from browser console after clicking bookmark it, no error flagged.
image
@devMunyi
Copy link
Author

See an error identified via Firefox console. Could it be the cause behind the disappearance of the bookmarklet toolbar. How do I get rid of this error, please.
image

@timotif
Copy link

timotif commented Aug 9, 2021

It seems to work fine there: you just pushed the button on a page with no pictures to get! Try on a wikipedia page or something (apparently google and amazon try to block the script)

@zenx
Copy link
Collaborator

zenx commented Sep 12, 2021

As @timotif commented, the behaviour is the expected one. @devMunyi, please try opening the bookmarklet in a website that contains images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zenx @devMunyi @timotif