Skip to content
This repository has been archived by the owner on Jul 28, 2024. It is now read-only.

Video Notification Support #7

Open
3 tasks done
occasionallyword opened this issue Jul 14, 2023 · 2 comments
Open
3 tasks done

Video Notification Support #7

occasionallyword opened this issue Jul 14, 2023 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@occasionallyword
Copy link

Checklist

  • I have filled out the template to the best of my ability.
  • This only contains 1 feature request (if you have multiple feature requests, open one feature request for each feature request).
  • This issue is not a duplicate feature request of previous feature requests.

Is your feature request related to a problem? Please describe.

Currently, it appears as if this tool supports text and image notifications. But, it seems to lack support for video notifications. It would be great if this support could be added, as it has a variety of uses.

Describe the solution you'd like

Video upload support for notifications.

Describe alternatives you've considered

Using a different tool

Additional context

N/A - it's a straightforward request : )

@PaarthShah
Copy link
Owner

Definitely entirely reasonable and it's very much on my roadmap!
Ideally shouldn't be particularly different from the current image support/make use of the same code paths.
Ideally someone looking to get their feet wet can take this on while I'm still working on config flow/encryption :^)

@PaarthShah PaarthShah added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Jul 16, 2023
@occasionallyword
Copy link
Author

occasionallyword commented Jul 17, 2023

A quick look at matrix-nio shows a function for send_image but not one for send_video. Their documentation also makes a reference to matrix-commander, which is built from matrix-nio, as having video upload support.

If on the chance that matrix-nio doesn't support it, I believe there's another python matrix sdk which should, called simplematrixbotlib. Not sure if that's within the scope of this project or not, but I figured I'd mention it anyways.

I'd love to poke at it myself, but I'm not sure I have the skills or the time. I would greatly benefit from the functionality, though.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants