Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: message versioning #3465

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

WIP: message versioning #3465

wants to merge 1 commit into from
+20 −0

Conversation

GuillaumeLaine
Copy link
Contributor

@GuillaumeLaine GuillaumeLaine commented Nov 20, 2024 •
edited
Loading

WIP

@GuillaumeLaine GuillaumeLaine mentioned this pull request Nov 20, 2024
Open
@github-actions GitHub Actions
Copy link

No flaws found

hamishwillee
hamishwillee reviewed Nov 20, 2024
View reviewed changes
en/middleware/uorb.md
@@ -141,10 +141,27 @@ Make sure not to mix `orb_advertise_multi` and `orb_advertise` for the same topi

The full API is documented in [platforms/common/uORB/uORBManager.hpp](https://github.com/PX4/PX4-Autopilot/blob/main/platforms/common/uORB/uORBManager.hpp).

## Message Versioning

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just FYI, this is how I mark up new content. On release I'll know the version number and replace this. You should also add a release note in https://docs.px4.io/main/en/releases/main.html , ideally with a link to any associated PRs.

I'll review properly when you tell me this is ready and/or when this moves out of draft. At that time would be good to link the various proposals that lead to this in the description.

Glad you are doing this and not me :-)

Suggested change
<Badge type="tip" text="main (PX4 v1.16+)" />

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamishwillee hamishwillee hamishwillee left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuillaumeLaine @hamishwillee