-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROS integration test updates #2970
base: main
Are you sure you want to change the base?
Conversation
I think that makes sense, and cross link. I think we need these to have a parent doc "Integration Testing". Thoughts? |
Yes it could be. How that would look like exactly isn't clear to me either though. Important will be that the tests run fast enough so we can have many. |
@bkueng I've added structure to the integration tests part as discussed, moving the ROS1/MAVROS based tests into a new doc and clearly marking as deprecated. We really do need that "Integrated PX4 and Companion" test story to be fleshed out. Fortunately I'm only here for my good looks, so someone who knows what they are doing will have to sort that out. Anyway, can you please sanity check this and if you're OK with it we can merge when your autopilot PR goes in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We really do need that "Integrated PX4 and Companion" test story to be fleshed out. Fortunately I'm only here for my good looks, so someone who knows what they are doing will have to sort that out.
You're just a bit too quick, it will happen eventually (I hope :). We barely even have some setpoints defined, and even less modes.
Thanks. Ready when you are! |
No flaws found |
@bkueng ANy plans to merge the PR this belongs to? |
Doc updates for
We can also move the library integration tests into a separate page under test_and_ci.