Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sonar Performance Degradation #32

Open
jgoppert opened this issue Jan 20, 2015 · 2 comments
Open

Sonar Performance Degradation #32

jgoppert opened this issue Jan 20, 2015 · 2 comments

Comments

@jgoppert
Copy link
Member

Master 91e6
master-91e6

Ae201 (before mode filter etc.)
revert-ae201

I believe that the complexities introduced by the on-board filtering are unwarranted for the performance gain. It also is causing a loss of information as the 0 return code is mapping both out of range close and out of range far to the same value. As a possible solution, I created a branch that adds an error status to the i2c frame (nominal, unint, low, high): jgoppert@9863563 This would also require the same change on the FMU side and some modification to position_estimator_inav.

@LorenzMeier
Copy link
Member

The suggestion makes sense.

@LorenzMeier
Copy link
Member

Hi James, how is this PR looking? Any chance to take another stab getting this into master? The issue I'm having is that the flow driver will probably silently fail - we need to introduce a version tag and escalate the issue to the GCS. Or we need to map near and far to e.g. -1 and -2 and keep the frame format intact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants