Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] PX4 Min PWM & Disarm PWM set to same values #24449

Open
afwilkin opened this issue Mar 5, 2025 · 9 comments
Open

[Bug] PX4 Min PWM & Disarm PWM set to same values #24449

afwilkin opened this issue Mar 5, 2025 · 9 comments

Comments

@afwilkin
Copy link
Contributor

afwilkin commented Mar 5, 2025

Describe the bug

After I reset all parameters to firmware defaults, select the Holybro x500 airframe, configure everything, and takeoff in stabilized flight mode, the propellers do not spin when armed. Only when we start to throttle up do they start to spin, which could be a bit disorienting for someone trying to bring up a new airframe.

To Reproduce

  1. Reflash PX4
  2. Reset all firmware defaults in QGC (Parameters->Tools-> Reset to all firmware defaults)
  3. Go through QGC and configure all red tabs (calibrate sensors, assign Flight modes, calibrate RC, etc...)
  4. Flip the drone into stabilized flight mode and arm. The motors shouldnt spin

Expected behavior

Motors spin on arm

Screenshot / Media

https://www.loom.com/share/f4d51a22a41f447e8565884861672368?sid=35965a9c-a580-4c99-87f3-3da5502c078e

Image

Flight Log

No response

Software Version

1.16 (but I also see this happening in 1.15)

Flight controller

Pixhawk 6c

Vehicle type

None

How are the different components wired up (including port information)

pwm escs

Additional context

No response

@afwilkin
Copy link
Contributor Author

afwilkin commented Mar 5, 2025

Going to try with the generic layout, but this was for the holybro x500...which is pretty widely used

@afwilkin
Copy link
Contributor Author

afwilkin commented Mar 5, 2025

Not an issue when selecting generic quadcopter as you are forced to select motor configurations which automatically get set to

PWM Min: 1100
PWM Max: 1900

@DronecodeBot
Copy link

This issue has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there:

https://discuss.px4.io/t/px4-sync-q-a-mar-04-2025/44169/2

@DronecodeBot
Copy link

This issue has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there:

https://discuss.px4.io/t/px4-sync-q-a-mar-04-2025/44169/1

@afwilkin
Copy link
Contributor Author

afwilkin commented Mar 5, 2025

We decided that we should take out those default functions for the x500 airframe, and investigate what other airframes this happens to .

we might want to SPECIFY that this is the ready to fly kit and not the almost ready to fly kit

@MaEtUgR
Copy link
Member

MaEtUgR commented Mar 5, 2025

@afwilkin Thanks for pointing this out! That's definitely something others run into.
The issue is that the PWM function must not be set without also configuring the correct PWM minimum and maximum values. This is wrong here:

param set-default PWM_MAIN_FUNC1 101
param set-default PWM_MAIN_FUNC2 102
param set-default PWM_MAIN_FUNC3 103
param set-default PWM_MAIN_FUNC4 104

Discussion in the dev call was:
X500 frame is close to QuadX default. Short term we should remove the Motor mappings. But to have a useful X500 airframe we should make it very clear that it's supposed to only be used with the ARF https://holybro.com/products/x500-v2-kits setup which is wired according to a guide and then the specific configuration makes sense. But if someone uses the X500 frame with random motors, ESCs, hopefully DSHOT he's better off using the generic QuadX as a start.

@afwilkin
Copy link
Contributor Author

afwilkin commented Mar 5, 2025

Deleted the lines and tested. Can confirm the Actuators tab becomes red and requires user to setup the correct motor mappings.

Image

Tested using the same steps here

Reflash PX4
Reset all firmware defaults in QGC (Parameters->Tools-> Reset to all firmware defaults)
Go through QGC and configure all red tabs (calibrate sensors, assign Flight modes, calibrate RC, etc...)
Flip the drone into stabilized flight mode and arm. The motors shouldnt spin

and the motors now spin when they arm.

PR: #24459

@afwilkin
Copy link
Contributor Author

afwilkin commented Mar 5, 2025

I dont want to completely close this because there are other airframes that set this as well

Image

@MaEtUgR I am unsure if we should unset all of these...or just wait until someone complains and then do it. I do not have all of the airframes that are listed here

@hamishwillee
Copy link
Contributor

hamishwillee commented Mar 6, 2025

@MaEtUgR Unless I'm missing something fundamental, the right approach is to add appropriate limits for the mapped PWM outputs, tuned for the ESC that are in the kit - see #24459 (comment)

Edit - as per linked/merged PR comment, the assembly of the kit isn't strictly enough defined to specify the outputs fixed to particular values.

Docs already reflect the desired behaviour - i.e. that you have to assign outputs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Status: Todo
Development

No branches or pull requests

4 participants