Miscellaneous housekeeping for v3.8.0 beta.

- Update list of contributors (preliminary).
- Fix typo in `scenes/portfolio/readme.txt`.
- Fix GitHub Workflow for automated builds.
- Update GitHub release build Workflow to earmark binary as official.

Author: c-lipka

.github/workflows/release_build.yml

@@ -14,7 +14,7 @@ jobs:
     name: 'Sanity-Check'
     runs-on: ubuntu-latest
     outputs:
-      do-build-installer: ${{ steps.check_validity.do-build-installer }}
+      do-build-installer: ${{ steps.check_validity.outputs.do-build-installer }}
     steps:
 
     - name: 'Check out Repository'
@@ -220,9 +220,10 @@ jobs:
       uses: microsoft/[email protected]
 
     - name: 'Build'
-      uses: POV-Ray/povray/.github/actions/windows_build@gh-actions-v1
+      uses: POV-Ray/povray/.github/actions/windows_build@gh-actions-v2
       with:
         pov-ray-build-id: gh${{github.run_number}}${{matrix.compatibility}}
+        pov-ray-special-sauce: ${{ secrets.POV_RAY_OFFICIAL_SAUCE_V3_8 }}
         solution: ${{matrix.solution-dir}}
         configuration: ${{matrix.configuration}}
         platform: ${{matrix.platform}}
@@ -321,21 +322,21 @@ jobs:
       uses: actions/checkout@v2
 
     - name: 'Retrieve Installer Artifacts for Release'
-      if: ${{ needs.build_windows_installer.status == 'success' }}
+      if: ${{ needs.build_windows_installer.result == 'success' }}
       uses: actions/download-artifact@v2
       with:
         name: artifact_installer
         path: installer
 
     - name: 'Retrieve Source Documentation Artifacts for Release'
-      if: ${{ needs.build_sourcedoc.status == 'success' }}
+      if: ${{ needs.build_sourcedoc.result == 'success' }}
       uses: actions/download-artifact@v2
       with:
         name: artifact_sourcedoc
         path: sourcedoc
 
     - name: 'Retrieve Unix Source Package Artifacts for Release'
-      if: ${{ needs.build_unix_package.status == 'success' }}
+      if: ${{ needs.build_unix_package.result == 'success' }}
       uses: actions/download-artifact@v2
       with:
         name: artifact_unix_package

distribution/scenes/portfolio/readme.txt

@@ -1,7 +1,7 @@
 
 The goal of the portfolio is to show most of
-the standard patterns, objects and and items
-in the standard include files.
+the standard patterns, objects and items in
+the standard include files.
 
 The portfolio is generated by rendering all
 the .INI files (except __empty.ini) in this

source/backend/povray.cpp

@@ -8,7 +8,7 @@
 /// @parblock
 ///
 /// Persistence of Vision Ray Tracer ('POV-Ray') version 3.8.
-/// Copyright 1991-2018 Persistence of Vision Raytracer Pty. Ltd.
+/// Copyright 1991-2021 Persistence of Vision Raytracer Pty. Ltd.
 ///
 /// POV-Ray is free software: you can redistribute it and/or modify
 /// it under the terms of the GNU Affero General Public License as
@@ -139,29 +139,40 @@ using namespace pov;
 using namespace pov_base;
 
 /// Primary Developers.
+/// `nullptr`-terminated list of primary developers of this "generation" of
+/// POV-Ray (as identified by the first two components of the version number).
+/// @note
+///     Please keep this list sorted by last name.
 const char *PrimaryDevelopers[] =
 {
     "Chris Cason",
-    "Thorsten Froehlich",
     "Christoph Lipka",
     nullptr
 };
 
 /// Assisting Developers.
+/// `nullptr`-terminated list of additional contributors to this "generation" of
+/// POV-Ray (as identified by the first two components of the version number).
+/// @note
+///     Please keep this list sorted by last name; contributors known only
+///     by some user name should go at the end, using simple ASCII sort order.
 const char *AssistingDevelopers[] =
 {
-    "Nicolas Calimet",
     "Jerome Grimbert",
     "James Holsenback",
-    "Christoph Hormann",
-    "Nathan Kopp",
-    "Juha Nieminen",
     "William F. Pokorny",
     nullptr
 };
 
 /// Past Contributing Developers.
-/// By convention, current developers are also already included here.
+/// `nullptr`-terminated list of contributors to previous "generations" of
+/// POV-Ray (as identified by the first two components of the version number).
+/// @note
+///     Please keep this list sorted by last name; contributors known only
+///     by some user name should go at the end, using simple ASCII sort order.
+/// @note
+///     By convention, current developers are also included here, provided they had
+///     already contributed to earlier "generations" of POV-Ray.
 const char *ContributingDevelopers[] =
 {
     "Steve Anger",
@@ -205,7 +216,7 @@ const char *ContributingDevelopers[] =
     "Timothy Wegner",
     "Drew Wells",
     "Chris Young",
-    nullptr   // `nullptr` flags the end of the list
+    nullptr
 };
 
 /// POVMS context to receive messages from the frontend

source/frontend/renderfrontend.cpp

@@ -8,7 +8,7 @@
 /// @parblock
 ///
 /// Persistence of Vision Ray Tracer ('POV-Ray') version 3.8.
-/// Copyright 1991-2018 Persistence of Vision Raytracer Pty. Ltd.
+/// Copyright 1991-2021 Persistence of Vision Raytracer Pty. Ltd.
 ///
 /// POV-Ray is free software: you can redistribute it and/or modify
 /// it under the terms of the GNU Affero General Public License as
@@ -747,6 +747,7 @@ void InitInfo(POVMS_Object& cppmsg, TextStreamBuffer *tsb)
     POVMSObject msgobj(cppmsg());
     POVMSObjectPtr msg = &msgobj;
     const int NUMBER_OF_AUTHORS_ACROSS = 4;
+    const char* FORMAT_OF_AUTHORS_ITEM = "  %-18s";
     POVMSAttributeList attrlist;
     POVMSAttribute item;
     char charbuf[1024];
@@ -762,7 +763,7 @@ void InitInfo(POVMS_Object& cppmsg, TextStreamBuffer *tsb)
 
     l = 1024;
     charbuf[0] = 0;
-    if (POVMSUtil_GetString(msg, kPOVAttrib_CoreVersion, charbuf, &l) == kNoErr)
+    if (POVMSUtil_GetString(msg, kPOVAttrib_CoreGeneration, charbuf, &l) == kNoErr)
         generation = charbuf;
 
     l = 1024;
@@ -788,7 +789,7 @@ void InitInfo(POVMS_Object& cppmsg, TextStreamBuffer *tsb)
                         l = 1023;
                         charbuf[0] = 0;
                         if(POVMSAttr_Get(&item, kPOVMSType_CString, charbuf, &l) == kNoErr)
-                            tsb->printf("  %-18s", charbuf);
+                            tsb->printf(FORMAT_OF_AUTHORS_ITEM, charbuf);
 
                         (void)POVMSAttr_Delete(&item);
                     }
@@ -817,7 +818,7 @@ void InitInfo(POVMS_Object& cppmsg, TextStreamBuffer *tsb)
                         l = 1023;
                         charbuf[0] = 0;
                         if(POVMSAttr_Get(&item, kPOVMSType_CString, charbuf, &l) == kNoErr)
-                            tsb->printf("  %-18s", charbuf);
+                            tsb->printf(FORMAT_OF_AUTHORS_ITEM, charbuf);
 
                         (void)POVMSAttr_Delete(&item);
                     }
@@ -846,7 +847,7 @@ void InitInfo(POVMS_Object& cppmsg, TextStreamBuffer *tsb)
                         l = 1023;
                         charbuf[0] = 0;
                         if(POVMSAttr_Get(&item, kPOVMSType_CString, charbuf, &l) == kNoErr)
-                            tsb->printf("  %-18s", charbuf);
+                            tsb->printf(FORMAT_OF_AUTHORS_ITEM, charbuf);
 
                         (void)POVMSAttr_Delete(&item);
                     }

unix/AUTHORS

@@ -1,14 +1,13 @@
 Persistence of Vision(tm) Ray Tracer Version 3.8.0.
 
 POV-Ray is based on DKBTrace 2.12 by David K. Buck & Aaron A. Collins
-Copyright 1991-2018 Persistence of Vision Raytracer Pty. Ltd.
+Copyright 1991-2021 Persistence of Vision Raytracer Pty. Ltd.
 
-Primary POV-Ray 3.7 Architects/Developers: (Alphabetically)
-  Chris Cason         Thorsten Froehlich  Christoph Lipka   
+Primary POV-Ray v3.8 Architects/Developers: (Alphabetically)
+  Chris Cason         Christoph Lipka
 
 With Assistance From: (Alphabetically)
-  Nicolas Calimet     Jerome Grimbert     James Holsenback    Christoph Hormann
-  Nathan Kopp         Juha Nieminen       William F. Pokorny
+  Jerome Grimbert     James Holsenback    William F. Pokorny
 
 Past Contributors: (Alphabetically)
   Steve Anger         Eric Barish         Dieter Bayer        David K. Buck

unix/povray.1

@@ -1,9 +1,9 @@
-.TH POV-Ray 1 "April 2018" "POV\-Team" "Version 3.8.0" \" -*- nroff -*-
+.TH POV-Ray 1 "July 2021" "POV\-Team" "Version 3.8.0" \" -*- nroff -*-
 .\" man page written by Andreas Dilger
-.\" updated by Mark Gordon for POV-Ray 3.5
-.\" updated by Nicolas Calimet and Christoph Hormann for POV-Ray 3.6
-.\" updated by James Holsenback for POV-Ray 3.7
-.\" updated by William F. Pokorny and Christoph Lipka for POV-Ray 3.8
+.\" updated by Mark Gordon for POV-Ray v3.5
+.\" updated by Nicolas Calimet and Christoph Hormann for POV-Ray v3.6
+.\" updated by James Holsenback for POV-Ray v3.7
+.\" updated by William F. Pokorny and Christoph Lipka for POV-Ray v3.8
 
 .SH NAME
 povray \- POV\-Ray: The Persistence of Vision Ray Tracer
@@ -29,7 +29,7 @@ or for a better explanation of the meaning of the
 command\-line and INI file options, please consult the online documentation
 at http://wiki.povray.org/content/Documentation:Contents or the documentation
 capture that should accompany all versions of \fBPOV\-Ray\fP. The documentation
-is installed in PREFIX/share/doc/povray-3.7, where PREFIX is /usr/local
+is installed in PREFIX/share/doc/povray-3.8, where PREFIX is /usr/local
 by default, or a path specified when configuring the source package for
 compilation and installation.
 .LP
@@ -272,12 +272,12 @@ Write the stream to the console and/or the specified file.  The streams are
 .LP
 \fBPOV\-Ray\fP for UNIX allows a \fIpovray.ini\fP file in the current
 directory to override the individual setting in
-\fI$HOME/.povray/3.7/povray.ini\fP.
+\fI$HOME/.povray/3.8/povray.ini\fP.
 \fBPOV\-Ray\fP looks for initial configuration information, like the
 Library_Path settings, which gives the location for the standard include
 files, first in the environment variable \fI$POVINI\fP, then in
-\fI./povray.ini\fP, then in \fI$HOME/.povray/3.7/povray.ini\fP, then in
-\fIPREFIX/etc/povray/3.7/povray.ini\fP. The PREFIX directory can be changed
+\fI./povray.ini\fP, then in \fI$HOME/.povray/3.8/povray.ini\fP, then in
+\fIPREFIX/etc/povray/3.8/povray.ini\fP. The PREFIX directory can be changed
 at compile\-time using the \-\-prefix option of the configure script.
 For backward compatibility with \fBPOV\-Ray\fP version 3.5 and earlier,
 the \fI$HOME/.povrayrc\fP and \fI$PREFIX/etc/povray.ini\fP files are also
@@ -287,9 +287,9 @@ Since version 3.5 \fBPOV\-Ray\fP features an I/O Restriction mechanism.
 I/O Restrictions attempt to at least partially protect a machine running
 \fBPOV-Ray\fP from having files read or written outside of a given set
 of directories. The settings are defined in two \fIconfiguration files\fP,
-a system-level \fIPREFIX/etc/povray/3.7/povray.conf\fP file and an user-level
-\fI$HOME/.povray/3.7/povray.conf\fP file with more restrictive settings.
-In \fBPOV-Ray\fP 3.7 the format of these configuration files has changed,
+a system-level \fIPREFIX/etc/povray/3.8/povray.conf\fP file and an user-level
+\fI$HOME/.povray/3.8/povray.conf\fP file with more restrictive settings.
+As of \fBPOV-Ray\fP v3.6 the format of these configuration files has changed,
 and no backward compatibility is retained with the configuration files
 in \fBPOV-Ray\fP 3.5. See the documentation for further details and
 examples of I/O Restriction settings.
@@ -333,15 +333,13 @@ http://news.povray.org/groups. You should try to find
 help and assistance in there before lodging a bug report.
 
 .SH AUTHORS
-Primary POV-Ray 3.7 Architects/Developers: (Alphabetically)
+Primary POV-Ray v3.8 Architects/Developers: (Alphabetically)
 .LP
-  Chris Cason         Thorsten Froehlich  Christoph Lipka
+  Chris Cason         Christoph Lipka
 .LP
 With Assistance From: (Alphabetically)
 .LP
-  Nicolas Calimet     Jerome Grimbert     James Holsenback
-  Christoph Hormann   Nathan Kopp         Juha Nieminen
-  William F. Pokorny
+  Jerome Grimbert     James Holsenback    William F. Pokorny
 .LP
 Past Contributors: (Alphabetically)
 .LP