-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MPNST samples generation is failing due to a dependency issue #204
Comments
Looks like "rjson" requires R version 4.4.0 which is higher than the mpnst DockerFile r-base:4.3.2. When I upgrade this version, rjson installs correctly. However, installing synapser gives the following error message. As a note, it says numpy is not found and installs a version using reticulate but numpy should already be installed in the environment. synapser installation error:
|
Yes, synapser failed to catch up to the numpy bug. This was finally addressed about 4 days ago, see comment on synapser github site. |
I don't think this was fully addressed as I ran into this current issue after the latest synapser release. I used R version 4.4.0 and Python 3.10. |
I think it is, since the update to the synapser docs came this week, and I haven't touched this code for over a month. Something shifted and requires updating to account for the new release. |
Hi all, just following a link here, but we also noticed the It's a bit unfortunate but since we ship for all 4 R versions, we pin the dependency of rjson to |
Thanks @thomasyu888. I've pinned rjson to However, the MPNST dataset is still not generating so I'll continue to track this here. Likely due to other dependancies or just things that have shifted in the code since the last version. |
Thanks @jjacobson95 for tagging me! You may also want to use |
Reproduced twice, same error each time.
Error:
Context:
The synapser R package is not being properly downloaded into the docker image, causing the build pipeline to fail. The reason is unknown, however it looks like you may have dealt with a dependency issue related to this recently.
Tracing the code we can see that the mpnst Dockerfile has an updated R base and instructions to install the requirements.r file. The requirements.r file includes the synapser package although the 'repos' argument differs from the documentation which was most recently updated on 8/21/24.
Dockerfile build logs confirm this is not installing correctly.
To fix, I will try updating the 'repos' argument in install.packages, and adding rjson to the requirements.r file.
Note:
If we create stable docker images, we should make sure to add a test for this.
To Reproduce:
nohup python3.10 build/build_all.py --all --pypi --figshare --version 0.1.41 > output_2.log 2>&1 &
aws_1.sh: Setup script 1
aws_2.sh: Setup script 2
The text was updated successfully, but these errors were encountered: