Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should all 'parallelization' related arguments be converted to `parallel_args'? #990

Open
jgostick opened this issue Oct 15, 2024 · 1 comment
Labels
api PR tag for breaking changes

Comments

@jgostick
Copy link
Member

We have some inconsistency in the way different function accept/expect parallelization arguments. Some accept a dict called parallel, others accept divs and then look at the settings to see how many cores to uses, etc. Both are not great.

I am thinking parallel_kw and it takes a dict of keyword arguments and passes them on as needed.

@jgostick jgostick added the api PR tag for breaking changes label Oct 15, 2024
@ma-sadeghi
Copy link
Member

Good point.

What if we just didn’t accept divs or any other parallelization-related kwargs? Since those are really part of global settings (which is why they’re stored in settings), they don’t belong in the function signature.

Then again, divs might be different since it helps avoid memory overflow on low-memory machines, so maybe we should keep it. But I still think the rest of the parallelization arguments don’t belong in the function signature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api PR tag for breaking changes
Projects
None yet
Development

No branches or pull requests

2 participants