New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust documentation or code for volume regionprop #979

Open

hzwirnmann opened this issue Jul 24, 2024 · 0 comments

hzwirnmann commented Jul 24, 2024

Hello everyone,

in scikit-image, the "area" regionprop is the number of pixels times the pixel area: https://github.com/scikit-image/scikit-image/blob/v0.24.0/skimage/measure/_regionprops.py#L425
There is a separate property "num_pixels" that just counts the number of pixels.

This should be reflected in this package, i.e. either the documentation of "volume" should be adjusted (
https://github.com/PMEAL/porespy/blob/dev/src/porespy/metrics/_regionprops.py#L165 ) or the code itself (
https://github.com/PMEAL/porespy/blob/dev/src/porespy/metrics/_regionprops.py#L245 ).

Best wishes
Henning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment