Unsupported operand types: string + string in date format (PHP 8.x)

[alaindev]

This is:

- [X ] a bug report
- [ ] a feature request
- [ ] **not** a usage question (ask them on https://stackoverflow.com/questions/tagged/phpspreadsheet or https://gitter.im/PHPOffice/PhpSpreadsheet)

What is the expected behavior?

detect returned string when calling fromString then skip operation
(line 132) $value = DateTimeExcel\DateValue::fromString($value) + DateTimeExcel\TimeValue::fromString($value);

What is the current behavior?

string+string is an issue in PHP 8.x
Fatal error: Uncaught TypeError: Unsupported operand types: string + string in C:\Program Files\EasyPHP-Devserver-17\eds-www\aplitec\includes\modules\phpoffice\phpspreadsheet\src\PhpSpreadsheet\Calculation\TextData\Format.php:132

What are the steps to reproduce?

save("crash.xlsx"); ?>

If this is an issue with reading a specific spreadsheet file, then it may be appropriate to provide a sample file that demonstrates the problem; but please keep it as small as possible, and sanitize any confidential information before uploading.

What features do you think are causing the issue

• Reader
• [ X] Writer
• Styles
• Data Validations
• Formula Calculations
• Charts
• AutoFilter
• Form Elements

Does an issue affect all spreadsheet file formats? If not, which formats are affected?

DATE Cell formatting when date cell is still a keyword and not yet a valid date!

Which versions of PhpSpreadsheet and PHP are affected? PHP >= 8.0

BUG_PHPSpreadsheet_PHP8_DATE.xlsx

[alaindev]

test code is :

save("crash.xlsx"); ?>

[oleibman]

Sorry, I don't even understand what your spreadsheet contains. C2 seems to contain [onload.datecalcullong]. Is that what it is supposed to contain? B4 seems to contain ="Crash on au "&TEXT(C2,"jj/mm/aaaa"), which Excel evaluates as Crash on [onload.datecalcullong]. PhpSpreadsheet evaluates it as a #VALUE error (and it does not throw an exception when I load and save). Possibly this is locale-related - I'll need to do some research about that. But, while I'm doing that, it would be helpful to know how you expect this to behave.

[oleibman]

It would be really helpful to know that you're not on the current release when you report a problem. You must be on 1.29.*. This problem was fixed by PR #3898, in response to some apparently good advice from Phpstan. The fix first became part of a release with 2.1.0. We are not able to backport most fixes to non-current releases. However, I will change this in the release129 branch. Since we just had a release yesterday, it probably won't be part of an official release for at least a few weeks.