You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Why should it return an integer instead of string is because the method is called columnIndex() and this change is for us to be consistent with the definition of index
the Coordinate class defines columnIndex as the index of the column [1 => A, 2 => B, 3 => C, ... ]
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
-
PhpSpreadsheet/src/PhpSpreadsheet/Worksheet/Column.php
Lines 42 to 48 in 88bbac9
The Code above should return
1
when column isA
using
Coordinate::columnIndexFromString('A')
Why should it return an
integer
instead ofstring
is because the method is calledcolumnIndex()
and this change is for us to be consistent with the definition ofindex
the
Coordinate
class definescolumnIndex
as the index of the column[1 => A, 2 => B, 3 => C, ... ]
we should call
A
ascolumnString
orcolumnKey
this is a breaking change so an
RFC
is neededBeta Was this translation helpful? Give feedback.
All reactions