Coding standards

Author: AndrewCarterUK

src/CallbackWrapper.php

@@ -17,9 +17,9 @@ class CallbackWrapper implements KernelInterface
 
     /**
      * Constructor.
-     * 
+     *
      * @param callable $handler The handler callback to wrap
-     * 
+     *
      * @throws \InvalidArgumentException When not given callable callback
      */
     public function __construct($handler)

src/Command/DaemonRunCommand.php

@@ -24,7 +24,7 @@ class DaemonRunCommand extends Command
 
     /**
      * Constructor.
-     * 
+     *
      * @param string                   $name          The name of the daemon run command
      * @param string                   $description   The description of the daemon run command
      * @param DaemonFactoryInterface   $daemonFactory The factory to use to create the daemon

src/Connection/StreamSocketConnection.php

@@ -33,16 +33,16 @@ public function __construct($socket)
 
     /**
      * Creates a formatted exception from the last error that occurecd.
-     * 
+     *
      * @param string $function The function that failed
-     * 
+     *
      * @return ConnectionException
      */
     protected function createExceptionFromLastError($function)
     {
         $this->close();
 
-        return new ConnectionException($function . ' failed');
+        return new ConnectionException($function.' failed');
     }
 
     /**

src/Connection/StreamSocketConnectionPool.php

@@ -70,7 +70,7 @@ public function operate(ConnectionHandlerFactoryInterface $connectionHandlerFact
 
             if (false === stream_select($read, $write, $except, $timeoutLoopSeconds, $timeoutLoopMicroseconds)) {
                 $lastError = error_get_last();
-     
+
                 if (null === $lastError) {
                     $this->logger->emergency('stream_select failed');
                 } else {
@@ -94,7 +94,7 @@ public function operate(ConnectionHandlerFactoryInterface $connectionHandlerFact
 
     /**
      * Accept incoming connections from the stream socket.
-     * 
+     *
      * @param ConnectionHandlerFactoryInterface $connectionHandlerFactory The factory used to create connection handlers
      */
     protected function acceptConnection(ConnectionHandlerFactoryInterface $connectionHandlerFactory)

src/ConnectionHandler/ConnectionHandler.php

@@ -108,7 +108,7 @@ public function close()
 
     /**
      * Read a record from the connection.
-     * 
+     *
      * @return array|null The record that has been read
      */
     protected function readRecord()
@@ -142,7 +142,7 @@ protected function readRecord()
 
     /**
      * Write a record to the connection.
-     * 
+     *
      * @param int    $requestId The request id to write to
      * @param int    $type      The type of record
      * @param string $content   The content of the record
@@ -162,7 +162,7 @@ protected function writeRecord($requestId, $type, $content = null)
 
     /**
      * Write a response to the connection as FCGI_STDOUT records.
-     * 
+     *
      * @param int             $requestId  The request id to write to
      * @param string          $headerData The header data to write (including terminating CRLFCRLF)
      * @param StreamInterface $stream     The stream to write
@@ -194,7 +194,7 @@ protected function writeResponse($requestId, $headerData, StreamInterface $strea
     /**
      * End the request by writing an FCGI_END_REQUEST record and then removing
      * the request from memory and closing the connection if necessary.
-     * 
+     *
      * @param int $requestId      The request id to end
      * @param int $appStatus      The application status to declare
      * @param int $protocolStatus The protocol status to declare
@@ -220,9 +220,9 @@ protected function endRequest($requestId, $appStatus = 0, $protocolStatus = Daem
 
     /**
      * Process a record.
-     * 
+     *
      * @param array $record The record that has been read
-     * 
+     *
      * @throws ProtocolException If the client sends an unexpected record.
      */
     protected function processRecord(array $record)
@@ -249,16 +249,16 @@ protected function processRecord(array $record)
                 break;
 
             default:
-                throw new ProtocolException('Unexpected packet of unkown type: ' . $record['type']);
+                throw new ProtocolException('Unexpected packet of unkown type: '.$record['type']);
         }
     }
 
     /**
      * Process a FCGI_BEGIN_REQUEST record.
-     * 
+     *
      * @param int    $requestId   The request id sending the record
      * @param string $contentData The content of the record
-     * 
+     *
      * @throws ProtocolException If the FCGI_BEGIN_REQUEST record is unexpected
      */
     protected function processBeginRequestRecord($requestId, $contentData)
@@ -285,10 +285,10 @@ protected function processBeginRequestRecord($requestId, $contentData)
 
     /**
      * Process a FCGI_PARAMS record.
-     * 
+     *
      * @param int    $requestId   The request id sending the record
      * @param string $contentData The content of the record
-     * 
+     *
      * @throws ProtocolException If the FCGI_PARAMS record is unexpected
      */
     protected function processParamsRecord($requestId, $contentData)
@@ -336,10 +336,10 @@ protected function processParamsRecord($requestId, $contentData)
 
     /**
      * Process a FCGI_STDIN record.
-     * 
+     *
      * @param int    $requestId   The request id sending the record
      * @param string $contentData The content of the record
-     * 
+     *
      * @throws ProtocolException If the FCGI_STDIN record is unexpected
      */
     protected function processStdinRecord($requestId, $contentData)
@@ -359,9 +359,9 @@ protected function processStdinRecord($requestId, $contentData)
 
     /**
      * Process a FCGI_ABORT_REQUEST record.
-     * 
+     *
      * @param int $requestId The request id sending the record
-     * 
+     *
      * @throws ProtocolException If the FCGI_ABORT_REQUEST record is unexpected
      */
     protected function processAbortRequestRecord($requestId)
@@ -375,9 +375,9 @@ protected function processAbortRequestRecord($requestId)
 
     /**
      * Dispatches a request to the kernel.
-     * 
+     *
      * @param int $requestId The request id that is ready to dispatch
-     * 
+     *
      * @throws DaemonException If there is an error dispatching the request
      */
     protected function dispatchRequest($requestId)
@@ -401,7 +401,7 @@ protected function dispatchRequest($requestId)
 
     /**
      * Sends the response to the client.
-     * 
+     *
      * @param int               $requestId The request id to respond to
      * @param ResponseInterface $response  The PSR-7 HTTP response message
      */
@@ -410,7 +410,7 @@ protected function sendResponse($requestId, ResponseInterface $response)
         $headerData = "Status: {$response->getStatusCode()} {$response->getReasonPhrase()}\r\n";
 
         foreach ($response->getHeaders() as $name => $values) {
-            $headerData .= $name . ': ' . implode(', ', $values) ."\r\n";
+            $headerData .= $name.': '.implode(', ', $values)."\r\n";
         }
 
         $headerData .= "\r\n";

src/Daemon.php

@@ -29,7 +29,7 @@ class Daemon implements DaemonInterface, LoggerAwareInterface
 
     /**
      * Constructor.
-     * 
+     *
      * @param ConnectionPoolInterface           $connectionPool           The connection pool to accept connections from
      * @param ConnectionHandlerFactoryInterface $connectionHandlerFactory A factory class for producing connection handlers
      * @param LoggerInterface                   $logger                   A logger to use

src/DaemonFactory.php

@@ -12,24 +12,24 @@ class DaemonFactory implements DaemonFactoryInterface
 {
     /**
      * {@inheritdoc}
-     * 
+     *
      * @codeCoverageIgnore
      */
     public function createDaemon($kernel)
     {
-        $socket = fopen('php://fd/' . DaemonInterface::FCGI_LISTENSOCK_FILENO, 'r');
+        $socket = fopen('php://fd/'.DaemonInterface::FCGI_LISTENSOCK_FILENO, 'r');
 
         return $this->createDaemonFromStreamSocket($kernel, $socket);
     }
 
     /**
      * {@inheritdoc}
-     * 
+     *
      * @codeCoverageIgnore
      */
     public function createTcpDaemon($kernel, $port, $host = 'localhost')
     {
-        $socket = stream_socket_server('tcp://' . $host . ':' . $port);
+        $socket = stream_socket_server('tcp://'.$host.':'.$port);
 
         return $this->createDaemonFromStreamSocket($kernel, $socket);
     }

src/DaemonFactoryInterface.php

@@ -11,9 +11,9 @@ interface DaemonFactoryInterface
 {
     /**
      * Create a FastCGI daemon listening on FCGI_LISTENSOCK_FILENO.
-     * 
+     *
      * @param KernelInterface|callable $kernel The daemon's kernel
-     * 
+     *
      * @return DaemonInterface The FastCGI daemon
      */
     public function createDaemon($kernel);
@@ -25,18 +25,18 @@ public function createDaemon($kernel);
      * @param KernelInterface|callable $kernel The daemon's kernel
      * @param int                      $port   The port to bind to
      * @param string                   $host   The host to bind to
-     * 
+     *
      * @return DaemonInterface The FastCGI daemon
      */
     public function createTcpDaemon($kernel, $port, $host = 'localhost');
 
     /**
      * Create a FastCGI daemon from a stream socket which is configured for
      * accepting connections.
-     * 
+     *
      * @param KernelInterface|callable $kernel The daemon's kernel
      * @param resource                 $socket The socket to accept connections from
-     * 
+     *
      * @return DaemonInterface The FastCGI daemon
      */
     public function createDaemonFromStreamSocket($kernel, $socket);

src/DaemonInterface.php

@@ -41,9 +41,9 @@ interface DaemonInterface
 
     /**
      * Run the daemon.
-     * 
+     *
      * This is a blocking method that does not return.
-     * 
+     *
      * @throws \Exception On fatal error
      */
     public function run();

src/KernelInterface.php

@@ -15,7 +15,7 @@ interface KernelInterface
      * Handles a request and returns a response.
      *
      * @param ServerRequestInterface $request The PSR-7 HTTP server request message
-     * 
+     *
      * @return ResponseInterface The PSR-7 HTTP server response message
      */
     public function handleRequest(ServerRequestInterface $request);