Don't assume stream_select will preserve array keys

It is not guaranteed that stream_select() will preserve the keys in the passed arrays. It seems that if the number of ready bytes is small, the keys are preserved, but for a larger numbers of bytes the array becomes 0-based.

With this patch, stream_select() is called with a copy of the $readSockets array and before returning the original keys are restored.

This fixes issue #30

Author: gaaf

src/Driver/Userland/Connection/StreamSocketConnectionPool.php

@@ -117,16 +117,28 @@ public function close()
      */
     private function selectConnections(&$readSockets, $timeout)
     {
+        // stream_select will not always preserve array keys
+        // call it with a (deep) copy so the original is preserved
+        $read = [];
+        foreach ($readSockets as $id => $socket) {
+            $read[] = $socket;
+        }
         $writeSockets = $exceptSockets = [];
 
-        if (false === @stream_select($readSockets, $writeSockets, $exceptSockets, $timeout)) {
+        if (false === @stream_select($read, $writeSockets, $exceptSockets, $timeout)) {
             $error = error_get_last();
 
             if (false === stripos($error['message'], 'interrupted system call')) {
                 throw new \RuntimeException('stream_select failed: '.$error['message']);
             }
 
             $readSockets = [];
+        } else {
+            $res = [];
+            foreach($read as $socket) {
+                $res[array_search($socket, $readSockets)] = $socket;
+            }
+            $readSockets = $res;
         }
     }