Tracking modern support lacking features

[Pablete1234]

Most if not all PGM features have been reimplemented in the newer features, with some exceptions:

• CanPlaceOn/CanBreak: Fixed in Update dependencies to 1.21.1 #1394
  • Removed in 1.20.6 spigot/paper due to changes in vanilla.
  • Hoping to add them back when they re-add them in 1.21 or something.
• Knockback reduction kit Fixed in Reimplement kb resistance in modern #1448
  • This relied on a sportpaper only patch to set a multiplier to the kb taken
  • Got it replaced with a knockback resistance attribute, since that's what it does in newer versions (in older versions it was a % chance of receiving 0 kb, instead of a multiplier on kb taken)
• Extra data in ping packet
  • This was also a sportpaper exclusive, we can't freely modify the ping packet to add extra data in paper
• Observers seeing invisible players Reimplement showInvisible in modern #1450
  • sportpaper exclusive. Obs will not be able to see invisible players.
  • Maybe can get this back by modifying packets in protocol lib.
• Hide all potion particles for players Reimplement setPotionParticles in modern #1449
  • sportpaper feature that PGM enabled by default on all kits who didn't explicitly disable it, only ghost squadron really disabled it.
  • Got this fully back by modifying packets in protocol lib
• Can't track entities spawned by dispensers (BlockDispenseEntityEvent) Fix dispenser and tnt tracking in modern #1451
  • If the spawned entity (arrow, spawn egg, tnt, etc) deals damage to someone, it doesn't count as yours for having placed the dispenser
  • This is likely very hard to work around, if at all possible
• Can't track who caused an explosion (eg: tnt or creeper) (ExplosionPrimeByEntityEvent) Fix dispenser and tnt tracking in modern #1451
  • When you shoot a tnt with flame, or light a creeper with flint & steep, it can't count that explosion as yours
  • When a TNT you lit, makes another tnt go off, it can't count it as yours either
  • This is likely very hard to work around, if at all possible
• EntityExtinguishEvent is missing, this should only be an internal technical issue as certain state doesn't get cleaned up, but shouldn't see feature differences.

[Brottweiler]

I hope these are relevant to this issue:

• The icons in the settings menu are all ink sacs, probably because they use damage values but are now items.
• potion duration="oo" should probably be made into actual infinite duration. [ref]
• Maps previously on level 0 are no longer at the void, consider adding a setting similar to maxbuildheight that determines the lowest possible build limit.
• Auto-learn all recipes (make sure to disable all advancements in spigot.yml.

[Brottweiler]

Also posting this here since it probably only affects modern.

[19:20:47 ERROR]: [PGM] [STDERR] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
[19:20:47 WARN]: Nag author(s): '[]' of 'PGM v0.16-SNAPSHOT (git-81fcde56)' about their usage of System.out/err.print. Please use your plugin's logger instead (JavaPlugin#getLogger).
[19:20:47 ERROR]: [PGM] [STDERR] SLF4J: Defaulting to no-operation (NOP) logger implementation
[19:20:47 ERROR]: [PGM] [STDERR] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
[19:20:50 WARN]: [PGM] "PGM v0.16-SNAPSHOT (git-81fcde56)" has registered a listener for org.bukkit.event.entity.EntityRemoveEvent on method "public void tc.oc.pgm.platform.modern.ModernListener.onEntityDespawn(org.bukkit.event.entity.EntityRemoveEvent)", but the event is Deprecated. "Server performance will be affected"; please notify the authors [].

[Pablete1234]

Also posting this here since it probably only affects modern.

[19:20:47 ERROR]: [PGM] [STDERR] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
[19:20:47 WARN]: Nag author(s): '[]' of 'PGM v0.16-SNAPSHOT (git-81fcde56)' about their usage of System.out/err.print. Please use your plugin's logger instead (JavaPlugin#getLogger).
[19:20:47 ERROR]: [PGM] [STDERR] SLF4J: Defaulting to no-operation (NOP) logger implementation
[19:20:47 ERROR]: [PGM] [STDERR] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
[19:20:50 WARN]: [PGM] "PGM v0.16-SNAPSHOT (git-81fcde56)" has registered a listener for org.bukkit.event.entity.EntityRemoveEvent on method "public void tc.oc.pgm.platform.modern.ModernListener.onEntityDespawn(org.bukkit.event.entity.EntityRemoveEvent)", but the event is Deprecated. "Server performance will be affected"; please notify the authors [].

I believe none of these can be fixed at the moment.

• PGM uses custom logging that gets the "usage of system.out"
• The event is a generic warning for using any deprecated event, in this case it will not have a performance problem and paper does not provide an API that can provide an alternative for it, yet.