-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query::delete() still hard delete #11
Comments
Unfortunately, I can't override what's done by an other plugin. Even if I overwrite the delete() method inside \SoftDelete\ORM\Query, it won't help since in your example Crud won't be using \SoftDelete\ORM\Query::delete() anyway, it is calling directly \Cake\ORM\Query::delete(). |
@PGBI It should be possible to override it in
As you can see, this query is already fine but here the query will be changed to a
|
First of all, it's an awesome plugin you have written. Unfortunately I have a problem in combination with FriendsOfCake/crud and the bulk delete action. As you can see here the bulk delete action uses
Query::delete()
to build the delete query. This will generate a hard delete query which is not modified from the soft delete plugin. Probably this issue also occurs in other use cases than crud.A possible solution would be to overwrite the
delete()
method insideORM/Query.php
which already exists in your plugin. @PGBI What do you think?The text was updated successfully, but these errors were encountered: