Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include PEtab version in tables #309

Closed
4 tasks
dweindl opened this issue Feb 20, 2020 · 2 comments
Closed
4 tasks

Include PEtab version in tables #309

dweindl opened this issue Feb 20, 2020 · 2 comments

Comments

@dweindl
Copy link
Member

dweindl commented Feb 20, 2020

As discussed yesterday, it might be helpful to encode the format version in all files.

@fbergmann suggested a separate header-only column.

Shall we go for petabVersion:${version}?

Required updates:

  • documentation
  • handling in validator: header in condition table does not have to match ID-schema
  • handling in parameter mapping: ignore that column of the condition table
  • for all other tables, this is just an additional column which is ignored anyways
  • I guess, that would demand raising the format version number
@LeonardSchmiester
Copy link
Collaborator

Shall we go for petabVersion:${version}?

Fine for me

@dweindl
Copy link
Member Author

dweindl commented Mar 29, 2022

As of #537, yaml files containing the PEtab version are mandatory. Therefore, I'd say this is obsolete.

@dweindl dweindl closed this as completed Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants